Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Mask shift amount before use in get_ue_golomb()

2015-12-12 Thread Michael Niedermayer
On Fri, Dec 11, 2015 at 04:24:43PM -0500, Ganesh Ajjanagadde wrote: > On Fri, Dec 11, 2015 at 4:14 PM, Andreas Cadhalpun > wrote: > > On 07.12.2015 00:27, Ganesh Ajjanagadde wrote: > >> On Sun, Dec 6, 2015 at 6:12 PM, Andreas Cadhalpun > >>

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Mask shift amount before use in get_ue_golomb()

2015-12-12 Thread Ganesh Ajjanagadde
On Sat, Dec 12, 2015 at 1:13 PM, Michael Niedermayer wrote: [...] > btw, if you feel something should be backported, dont hesitate to > push cherry picked commits to the release branches > (with cherry-pick -x) > if you are unsure if somethig should be cherry picked, dont

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Mask shift amount before use in get_ue_golomb()

2015-12-11 Thread Ganesh Ajjanagadde
On Fri, Dec 11, 2015 at 4:14 PM, Andreas Cadhalpun wrote: > On 07.12.2015 00:27, Ganesh Ajjanagadde wrote: >> On Sun, Dec 6, 2015 at 6:12 PM, Andreas Cadhalpun >> wrote: >>> On 06.12.2015 22:48, Michael Niedermayer wrote:

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Mask shift amount before use in get_ue_golomb()

2015-12-11 Thread Andreas Cadhalpun
On 07.12.2015 00:27, Ganesh Ajjanagadde wrote: > On Sun, Dec 6, 2015 at 6:12 PM, Andreas Cadhalpun > wrote: >> On 06.12.2015 22:48, Michael Niedermayer wrote: >>> my concern is more on h264 (CAVLC) and hevc speed >> >> I tested with 444_8bit_cavlc.h264 added 100

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Mask shift amount before use in get_ue_golomb()

2015-12-06 Thread Andreas Cadhalpun
On 06.12.2015 22:48, Michael Niedermayer wrote: > On Sun, Dec 06, 2015 at 08:26:41PM +0100, Andreas Cadhalpun wrote: >> On 05.12.2015 03:12, Michael Niedermayer wrote: >>> On Fri, Dec 04, 2015 at 10:28:35PM +0100, Andreas Cadhalpun wrote: On 03.12.2015 23:09, Michael Niedermayer wrote: >

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Mask shift amount before use in get_ue_golomb()

2015-12-06 Thread Ganesh Ajjanagadde
On Sun, Dec 6, 2015 at 6:12 PM, Andreas Cadhalpun wrote: > On 06.12.2015 22:48, Michael Niedermayer wrote: >> On Sun, Dec 06, 2015 at 08:26:41PM +0100, Andreas Cadhalpun wrote: >>> On 05.12.2015 03:12, Michael Niedermayer wrote: On Fri, Dec 04, 2015 at

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Mask shift amount before use in get_ue_golomb()

2015-12-06 Thread Michael Niedermayer
On Mon, Dec 07, 2015 at 12:12:54AM +0100, Andreas Cadhalpun wrote: > On 06.12.2015 22:48, Michael Niedermayer wrote: > > On Sun, Dec 06, 2015 at 08:26:41PM +0100, Andreas Cadhalpun wrote: > >> On 05.12.2015 03:12, Michael Niedermayer wrote: > >>> On Fri, Dec 04, 2015 at 10:28:35PM +0100, Andreas

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Mask shift amount before use in get_ue_golomb()

2015-12-06 Thread Michael Niedermayer
On Sun, Dec 06, 2015 at 08:26:41PM +0100, Andreas Cadhalpun wrote: > On 05.12.2015 03:12, Michael Niedermayer wrote: > > On Fri, Dec 04, 2015 at 10:28:35PM +0100, Andreas Cadhalpun wrote: > >> On 03.12.2015 23:09, Michael Niedermayer wrote: > >>> diff --git a/libavcodec/golomb.h

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Mask shift amount before use in get_ue_golomb()

2015-12-06 Thread Andreas Cadhalpun
On 05.12.2015 03:12, Michael Niedermayer wrote: > On Fri, Dec 04, 2015 at 10:28:35PM +0100, Andreas Cadhalpun wrote: >> On 03.12.2015 23:09, Michael Niedermayer wrote: >>> diff --git a/libavcodec/golomb.h b/libavcodec/golomb.h >>> index d30bb6b..323665d 100644 >>> --- a/libavcodec/golomb.h >>> +++

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Mask shift amount before use in get_ue_golomb()

2015-12-05 Thread Ganesh Ajjanagadde
On Fri, Dec 4, 2015 at 9:12 PM, Michael Niedermayer wrote: > On Fri, Dec 04, 2015 at 10:28:35PM +0100, Andreas Cadhalpun wrote: >> On 03.12.2015 23:09, Michael Niedermayer wrote: >> > From: Michael Niedermayer >> > >> > Fixes undefined behavior >> >

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Mask shift amount before use in get_ue_golomb()

2015-12-04 Thread Andreas Cadhalpun
On 03.12.2015 23:09, Michael Niedermayer wrote: > From: Michael Niedermayer > > Fixes undefined behavior > Fixes: mozilla bug 1229208 > Fixes: > fbeb8b2c7c996e9b91c6b1af319d7ebc/asan_heap-oob_195450f_2743_e8856ece4579ea486670be2b236099a0.bit > > Found-by: Tyson Smith >

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Mask shift amount before use in get_ue_golomb()

2015-12-04 Thread Michael Niedermayer
On Fri, Dec 04, 2015 at 10:28:35PM +0100, Andreas Cadhalpun wrote: > On 03.12.2015 23:09, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > Fixes undefined behavior > > Fixes: mozilla bug 1229208 > > Fixes: > >

[FFmpeg-devel] [PATCH] avcodec/golomb: Mask shift amount before use in get_ue_golomb()

2015-12-03 Thread Michael Niedermayer
From: Michael Niedermayer Fixes undefined behavior Fixes: mozilla bug 1229208 Fixes: fbeb8b2c7c996e9b91c6b1af319d7ebc/asan_heap-oob_195450f_2743_e8856ece4579ea486670be2b236099a0.bit Found-by: Tyson Smith Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Mask shift amount before use in get_ue_golomb()

2015-12-03 Thread Ganesh Ajjanagadde
On Thu, Dec 3, 2015 at 5:09 PM, Michael Niedermayer wrote: > From: Michael Niedermayer > > Fixes undefined behavior > Fixes: mozilla bug 1229208 > Fixes: > fbeb8b2c7c996e9b91c6b1af319d7ebc/asan_heap-oob_195450f_2743_e8856ece4579ea486670be2b236099a0.bit