Re: [FFmpeg-devel] [PATCH] avcodec/h264, videotoolbox: do not return invalid frames on failure

2015-11-20 Thread wm4
On Tue, 17 Nov 2015 15:19:29 +0100 wm4 wrote: > If videotoolbox_common_end_frame failed, then the AVFrame was returned > to the API user with the dummy buffer (in AVFrame.buf[0]) still set, and > the decode call indicating success. > > These "half-set" AVFrames with dummy buffer are a videotoolb

Re: [FFmpeg-devel] [PATCH] avcodec/h264, videotoolbox: do not return invalid frames on failure

2015-11-18 Thread wm4
On Wed, 18 Nov 2015 15:09:48 +0100 Michael Niedermayer wrote: > On Tue, Nov 17, 2015 at 03:19:29PM +0100, wm4 wrote: > > If videotoolbox_common_end_frame failed, then the AVFrame was returned > > to the API user with the dummy buffer (in AVFrame.buf[0]) still set, and > > the decode call indicati

Re: [FFmpeg-devel] [PATCH] avcodec/h264, videotoolbox: do not return invalid frames on failure

2015-11-18 Thread Michael Niedermayer
On Tue, Nov 17, 2015 at 03:19:29PM +0100, wm4 wrote: > If videotoolbox_common_end_frame failed, then the AVFrame was returned > to the API user with the dummy buffer (in AVFrame.buf[0]) still set, and > the decode call indicating success. > > These "half-set" AVFrames with dummy buffer are a video

[FFmpeg-devel] [PATCH] avcodec/h264, videotoolbox: do not return invalid frames on failure

2015-11-17 Thread wm4
If videotoolbox_common_end_frame failed, then the AVFrame was returned to the API user with the dummy buffer (in AVFrame.buf[0]) still set, and the decode call indicating success. These "half-set" AVFrames with dummy buffer are a videotoolbox specific hack, because the decoder requires an allocate