Re: [FFmpeg-devel] [PATCH] avcodec/h264_parser: set missing pts for top/bottom field frames

2016-09-14 Thread Paul B Mahol
On 9/14/16, Michael Niedermayer wrote: > On Wed, Sep 14, 2016 at 04:42:59PM +0200, Paul B Mahol wrote: >> Adopted from 4eb49fdde8f84d54a763cfb5d355527b525ee2bf revert. >> >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/h264_parser.c | 22

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parser: set missing pts for top/bottom field frames

2016-09-14 Thread Carl Eugen Hoyos
Hi! 2016-09-14 19:35 GMT+02:00 Paul B Mahol : > I see nothing wrong doing this in parser instead of in generic code. I am not saying there is anything wrong. I wanted to share my suspicion that this patch is a work-around for a bug that affects h.264 decoding in general. (And

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parser: set missing pts for top/bottom field frames

2016-09-14 Thread Paul B Mahol
On 9/14/16, Carl Eugen Hoyos wrote: > 2016-09-14 18:11 GMT+02:00 Paul B Mahol : >> On Wednesday, September 14, 2016, Carl Eugen Hoyos wrote: >> >>> 2016-09-14 16:42 GMT+02:00 Paul B Mahol : >>> > Adopted from

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parser: set missing pts for top/bottom field frames

2016-09-14 Thread Carl Eugen Hoyos
2016-09-14 18:11 GMT+02:00 Paul B Mahol : > On Wednesday, September 14, 2016, Carl Eugen Hoyos wrote: > >> 2016-09-14 16:42 GMT+02:00 Paul B Mahol : >> > Adopted from 4eb49fdde8f84d54a763cfb5d355527b525ee2bf revert. >> >> I am of course not against this patch

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parser: set missing pts for top/bottom field frames

2016-09-14 Thread Paul B Mahol
On Wednesday, September 14, 2016, Carl Eugen Hoyos wrote: > 2016-09-14 16:42 GMT+02:00 Paul B Mahol >: > > Adopted from 4eb49fdde8f84d54a763cfb5d355527b525ee2bf revert. > > I am of course not against this patch but wasn't the reason for the >

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parser: set missing pts for top/bottom field frames

2016-09-14 Thread Michael Niedermayer
On Wed, Sep 14, 2016 at 04:42:59PM +0200, Paul B Mahol wrote: > Adopted from 4eb49fdde8f84d54a763cfb5d355527b525ee2bf revert. > > Signed-off-by: Paul B Mahol > --- > libavcodec/h264_parser.c | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parser: set missing pts for top/bottom field frames

2016-09-14 Thread Carl Eugen Hoyos
2016-09-14 16:42 GMT+02:00 Paul B Mahol : > Adopted from 4eb49fdde8f84d54a763cfb5d355527b525ee2bf revert. I am of course not against this patch but wasn't the reason for the old code in utils.c that our h264 parser has insufficiencies? Carl Eugen

[FFmpeg-devel] [PATCH] avcodec/h264_parser: set missing pts for top/bottom field frames

2016-09-14 Thread Paul B Mahol
Adopted from 4eb49fdde8f84d54a763cfb5d355527b525ee2bf revert. Signed-off-by: Paul B Mahol --- libavcodec/h264_parser.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/libavcodec/h264_parser.c b/libavcodec/h264_parser.c index 615884f..cf6c3d1 100644