Re: [FFmpeg-devel] [PATCH] avcodec/mfenc: expose more properties of the media foundation encoder

2024-04-02 Thread Mark Thompson
On 01/04/2024 19:55, Mark Thompson wrote: On 01/04/2024 17:25, Mark Samuelson wrote: On Mon, Apr 1, 2024 at 10:06 AM Mark Thompson wrote: On 28/03/2024 12:34, Mark Samuelson wrote: Thank you for the notes, here is a new patch that incorporates your suggestions.  You are right, the default

Re: [FFmpeg-devel] [PATCH] avcodec/mfenc: expose more properties of the media foundation encoder

2024-04-01 Thread Mark Thompson
On 01/04/2024 17:25, Mark Samuelson wrote: On Mon, Apr 1, 2024 at 10:06 AM Mark Thompson wrote: On 28/03/2024 12:34, Mark Samuelson wrote: Thank you for the notes, here is a new patch that incorporates your suggestions. You are right, the default value of 12 for gop_size is suprising, I

Re: [FFmpeg-devel] [PATCH] avcodec/mfenc: expose more properties of the media foundation encoder

2024-04-01 Thread Mark Samuelson
On Mon, Apr 1, 2024 at 10:06 AM Mark Thompson wrote: > > On 28/03/2024 12:34, Mark Samuelson wrote: > > > Thank you for the notes, here is a new patch that incorporates your > suggestions. You are right, the default value of 12 for gop_size is > suprising, I didn't know about it before now. > >

Re: [FFmpeg-devel] [PATCH] avcodec/mfenc: expose more properties of the media foundation encoder

2024-04-01 Thread Mark Thompson
On 28/03/2024 12:34, Mark Samuelson wrote: Thank you for the notes, here is a new patch that incorporates your suggestions. You are right, the default value of 12 for gop_size is suprising, I didn't know about it before now. --- libavcodec/mf_utils.h | 5 + libavcodec/mfenc.c| 33

[FFmpeg-devel] [PATCH] avcodec/mfenc: expose more properties of the media foundation encoder

2024-03-28 Thread Mark Samuelson
Thank you for the notes, here is a new patch that incorporates your suggestions. You are right, the default value of 12 for gop_size is suprising, I didn't know about it before now. --- libavcodec/mf_utils.h | 5 + libavcodec/mfenc.c| 33 +++-- 2 files

Re: [FFmpeg-devel] [PATCH] avcodec/mfenc: expose more properties of the media foundation encoder

2024-03-27 Thread Stefano Sabatini
On date Tuesday 2024-03-26 14:25:37 -0500, Mark Samuelson wrote: > --- > libavcodec/mf_utils.h | 5 + > libavcodec/mfenc.c| 19 +++ > 2 files changed, 24 insertions(+) > > diff --git a/libavcodec/mf_utils.h b/libavcodec/mf_utils.h > index aebfb9ad21..387c005f38 100644 >

Re: [FFmpeg-devel] [PATCH] avcodec/mfenc: expose more properties of the media foundation encoder

2024-03-26 Thread Mark Thompson
On 26/03/2024 19:25, Mark Samuelson wrote: --- libavcodec/mf_utils.h | 5 + libavcodec/mfenc.c| 19 +++ 2 files changed, 24 insertions(+) This seems like a good idea. diff --git a/libavcodec/mf_utils.h b/libavcodec/mf_utils.h index aebfb9ad21..387c005f38 100644

[FFmpeg-devel] [PATCH] avcodec/mfenc: expose more properties of the media foundation encoder

2024-03-26 Thread Mark Samuelson
--- libavcodec/mf_utils.h | 5 + libavcodec/mfenc.c| 19 +++ 2 files changed, 24 insertions(+) diff --git a/libavcodec/mf_utils.h b/libavcodec/mf_utils.h index aebfb9ad21..387c005f38 100644 --- a/libavcodec/mf_utils.h +++ b/libavcodec/mf_utils.h @@ -97,6 +97,11 @@