Re: [FFmpeg-devel] [PATCH] avcodec/options_table: remove extradata_size from the AVOptions table

2015-03-09 Thread Michael Niedermayer
On Mon, Mar 09, 2015 at 03:42:00AM +0100, Michael Niedermayer wrote: > allowing access to the size but not the extradata itself is not useful > and could lead to potential problems if writing happens through this field > > Signed-off-by: Michael Niedermayer > --- > libavcodec/options_table.h |

Re: [FFmpeg-devel] [PATCH] avcodec/options_table: remove extradata_size from the AVOptions table

2015-03-09 Thread Michael Niedermayer
On Mon, Mar 09, 2015 at 05:33:46PM +0100, Nicolas George wrote: > Le nonidi 19 ventôse, an CCXXIII, Michael Niedermayer a écrit : > > you miss the problem, this is a demuxer side problem, > > a attacker can at least crash your application no muxer side change > > can fix this, the attacker has his

Re: [FFmpeg-devel] [PATCH] avcodec/options_table: remove extradata_size from the AVOptions table

2015-03-09 Thread Nicolas George
Le nonidi 19 ventôse, an CCXXIII, Michael Niedermayer a écrit : > you miss the problem, this is a demuxer side problem, > a attacker can at least crash your application no muxer side change > can fix this, the attacker has his own self written muxer that > produces a mallicious bitstream (Unrelate

Re: [FFmpeg-devel] [PATCH] avcodec/options_table: remove extradata_size from the AVOptions table

2015-03-09 Thread Lukasz Marek
On 9 March 2015 at 14:28, Michael Niedermayer wrote: > On Mon, Mar 09, 2015 at 01:27:58PM +0100, Lukasz Marek wrote: > > On 9 March 2015 at 12:19, Andreas Cadhalpun < > > andreas.cadhal...@googlemail.com> wrote: > > > > > On 09.03.2015 03:42, Michael Niedermayer wrote: > > > > > >> allowing acces

Re: [FFmpeg-devel] [PATCH] avcodec/options_table: remove extradata_size from the AVOptions table

2015-03-09 Thread Michael Niedermayer
On Mon, Mar 09, 2015 at 01:27:58PM +0100, Lukasz Marek wrote: > On 9 March 2015 at 12:19, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > > > On 09.03.2015 03:42, Michael Niedermayer wrote: > > > >> allowing access to the size but not the extradata itself is not useful > >> and co

Re: [FFmpeg-devel] [PATCH] avcodec/options_table: remove extradata_size from the AVOptions table

2015-03-09 Thread Lukasz Marek
On 9 March 2015 at 12:19, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 09.03.2015 03:42, Michael Niedermayer wrote: > >> allowing access to the size but not the extradata itself is not useful >> and could lead to potential problems if writing happens through this field >> >> S

Re: [FFmpeg-devel] [PATCH] avcodec/options_table: remove extradata_size from the AVOptions table

2015-03-09 Thread Andreas Cadhalpun
On 09.03.2015 03:42, Michael Niedermayer wrote: allowing access to the size but not the extradata itself is not useful and could lead to potential problems if writing happens through this field Signed-off-by: Michael Niedermayer --- libavcodec/options_table.h |1 - 1 file changed, 1 dele

[FFmpeg-devel] [PATCH] avcodec/options_table: remove extradata_size from the AVOptions table

2015-03-08 Thread Michael Niedermayer
allowing access to the size but not the extradata itself is not useful and could lead to potential problems if writing happens through this field Signed-off-by: Michael Niedermayer --- libavcodec/options_table.h |1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/options_table.h b/l