Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-05-28 Thread Paul B Mahol
On 5/28/19, velocit...@gmail.com wrote: > From: Nick Renieris > > In DNG images with the .tiff extension, it solves the issue where the > TIFF thumbnail in IFD 0 was incorrectly parsed (related confusion: [1]). > Embedded thumbnails for DNG images can still be decoded with the added >

[FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-05-28 Thread velocityra
From: Nick Renieris In DNG images with the .tiff extension, it solves the issue where the TIFF thumbnail in IFD 0 was incorrectly parsed (related confusion: [1]). Embedded thumbnails for DNG images can still be decoded with the added "-dng_thumb" option. Additionally: - Renamed

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-04-02 Thread Paul B Mahol
On 4/2/19, Nick Renieris wrote: > I don't mind either way, but I'm writing my GSoC proposal at the > moment and wanted an answer. > > If there's no clear answer, is it something TBD that I don't need to > specify in the proposal? I do not think we can use libdng.

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-04-02 Thread Nick Renieris
I don't mind either way, but I'm writing my GSoC proposal at the moment and wanted an answer. If there's no clear answer, is it something TBD that I don't need to specify in the proposal? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-04-02 Thread Nick Renieris
Any consensus on using libdng? Στις Τετ, 20 Μαρ 2019 στις 5:03 μ.μ., ο/η Nick Renieris έγραψε: > > Στις Τετ, 20 Μαρ 2019 στις 4:17 μ.μ., ο/η Paul B Mahol > έγραψε: > > DNG I posted should be decodeable by default, without need for extra > > option(s). > > The DNG contents themselves? As in,

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-20 Thread Nick Renieris
Στις Τετ, 20 Μαρ 2019 στις 4:17 μ.μ., ο/η Paul B Mahol έγραψε: > DNG I posted should be decodeable by default, without need for extra > option(s). The DNG contents themselves? As in, not just the thumbnail? That's what the whole GSoC proposal is about though... What about: >On Tue, Mar 19, 2019

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-20 Thread Paul B Mahol
On 3/20/19, Nick Renieris wrote: > Hello, > >>Similarly if we support demuxing "auxilary / secondary or what they are >> called images" and muxing then we should be able to connect these and not >> just be able to extract one image. >>Thats the ideal. The question how to implement this, or if

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-19 Thread Nick Renieris
Hello, >Similarly if we support demuxing "auxilary / secondary or what they are called >images" and muxing then we should be able to connect these and not just be >able to extract one image. >Thats the ideal. The question how to implement this, or if this is the way to >go or if this is too

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-19 Thread Michael Niedermayer
On Tue, Mar 19, 2019 at 03:03:20AM +0200, Nick Renieris wrote: > Yes, obviously this is not complete. As was said, the DNG spec is huge > and I did bring up this concern in a personal email to Paul a few days > ago. > I was told that: > > 3 months should be enough to finish most of specification,

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-18 Thread Nick Renieris
Yes, obviously this is not complete. As was said, the DNG spec is huge and I did bring up this concern in a personal email to Paul a few days ago. I was told that: > 3 months should be enough to finish most of specification, note you work on > real world DNG files, so if some feature from spec is

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-18 Thread Michael Niedermayer
On Mon, Mar 18, 2019 at 09:13:01AM +0100, Moritz Barsnick wrote: > On Sun, Mar 17, 2019 at 23:05:01 +0100, Paul B Mahol wrote: > > Still wrong, You can decode images you linked just fine (albeit with > > incorrect colors) with command: > > > > ffmpeg -subimage 1 -i IMAGE.dng rest of command.

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-18 Thread Lauri Kasanen
On Mon, 18 Mar 2019 09:13:01 +0100 Moritz Barsnick wrote: > On Sun, Mar 17, 2019 at 23:05:01 +0100, Paul B Mahol wrote: > > Still wrong, You can decode images you linked just fine (albeit with > > incorrect colors) with command: > > > > ffmpeg -subimage 1 -i IMAGE.dng rest of command. > >

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-18 Thread Paul B Mahol
On 3/18/19, velocit...@gmail.com wrote: > From: Nick Renieris > > Prints "DNG images are not supported" if it finds a TIFF image with > the 'DNGVersion' tag. In DNG images with the .tiff extension, it > solves the issue where the TIFF thumbnail in IFD 0 was incorrectly > parsed (related

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-18 Thread Moritz Barsnick
On Sun, Mar 17, 2019 at 23:05:01 +0100, Paul B Mahol wrote: > Still wrong, You can decode images you linked just fine (albeit with > incorrect colors) with command: > > ffmpeg -subimage 1 -i IMAGE.dng rest of command. Shouldn't, ideally, these image files be demuxed as two image streams?

[FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread velocityra
From: Nick Renieris Prints "DNG images are not supported" if it finds a TIFF image with the 'DNGVersion' tag. In DNG images with the .tiff extension, it solves the issue where the TIFF thumbnail in IFD 0 was incorrectly parsed (related confusion: [1]). The user can still decode those with the

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread Nick Renieris
Στις Δευ, 18 Μαρ 2019 στις 12:05 π.μ., ο/η Paul B Mahol έγραψε: > Still wrong, You can decode images you linked just fine (albeit with > incorrect colors) with command: > > ffmpeg -subimage 1 -i IMAGE.dng rest of command. Oh ok, I thought you agreed to go with the -thumbnail option I

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread Paul B Mahol
On 3/17/19, velocit...@gmail.com wrote: > From: Nick Renieris > > Prints "DNG images are not supported" if it finds a TIFF image with > the 'DNGVersion' tag. In DNG images with the .tiff extension it, > solves the issue where the TIFF thumbnail in IFD 0 was incorrectly > parsed (related

[FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread velocityra
From: Nick Renieris Prints "DNG images are not supported" if it finds a TIFF image with the 'DNGVersion' tag. In DNG images with the .tiff extension it, solves the issue where the TIFF thumbnail in IFD 0 was incorrectly parsed (related confusion: [1]). Adds an option (-dng_thumbnail) for

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread Nick Renieris
Στις Κυρ, 17 Μαρ 2019 στις 10:41 μ.μ., ο/η Paul B Mahol έγραψε: > Give link to input you use. All DNGs I've tried. An example is the samples linked in the ticket: https://kenrockwell.com/leica/m9/sample-photos-3.htm Running ffmpeg -i L1004220.DNG out.jpg with the 'return AVERROR_PATCHWELCOME;'

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread Paul B Mahol
On 3/17/19, Nick Renieris wrote: > Στις Κυρ, 17 Μαρ 2019 στις 8:34 μ.μ., ο/η Paul B Mahol > έγραψε: >> Please try with option adding instead(-subimage). It will ignore >> thumbnail and try to decode rest of image. >> Anyhow the return statement is invalid, as it breaks support for files >> that

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread Nick Renieris
Στις Κυρ, 17 Μαρ 2019 στις 8:34 μ.μ., ο/η Paul B Mahol έγραψε: > Please try with option adding instead(-subimage). It will ignore > thumbnail and try to decode rest of image. > Anyhow the return statement is invalid, as it breaks support for files > that are already working just fine. Sorry, I

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread Nick Renieris
Στις Κυρ, 17 Μαρ 2019 στις 10:43 π.μ., ο/η Paul B Mahol έγραψε: > Are you sure that this does not break support with previously supported files. > Please remove return statement. By "support" you mean the thumbnail thing? Did you read the StackExchange question? I would consider it more of a bug

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread Carl Eugen Hoyos
Am So., 17. März 2019 um 08:46 Uhr schrieb : > -case TIFF_WHITE_LEVEL: > +case DNG_WHITE_LEVEL: Why is this a good change? > @@ -1389,6 +1405,11 @@ again: > return ret; > } > > +if (s->dng_mode) { > +av_log(avctx, AV_LOG_ERROR, "DNG images are not

[FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread velocityra
From: Nick Renieris Prints "DNG images are not supported" if it finds a TIFF image with the 'DNGVersion' tag. In DNG images with the .tiff extension it, solves the issue where the TIFF thumbnail in IFD 0 was incorrectly parsed (related confusion: [1]). Also prints the DNG version of the file