Re: [FFmpeg-devel] [PATCH] avcodec/wma: handle run_level_decode error

2021-08-24 Thread Ronald S. Bultje
Hi, On Tue, Aug 24, 2021 at 9:07 AM Olivier Crête wrote: > Hi Andreas, > > > Generally, one should forward error codes and not make up some on the > > fly; in this case, the callee does not return proper error codes, so > > this should be fixed, too (but not in the same commit and not > > necess

Re: [FFmpeg-devel] [PATCH] avcodec/wma: handle run_level_decode error

2021-08-24 Thread Olivier Crête
Hi Andreas, > Generally, one should forward error codes and not make up some on the > fly; in this case, the callee does not return proper error codes, so > this should be fixed, too (but not in the same commit and not > necessarily by you). Even more importantly, the callee emits an error > messa

Re: [FFmpeg-devel] [PATCH] avcodec/wma: handle run_level_decode error

2021-08-11 Thread Andreas Rheinhardt
Stéphane Cerveau: > Consider data as invalid if ff_wma_run_level_decode > gets out with an error. > > It avoids an unpleasant sound distorsion. > > See http://trac.ffmpeg.org/ticket/9358 > --- > libavcodec/wmadec.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/li

[FFmpeg-devel] [PATCH] avcodec/wma: handle run_level_decode error

2021-08-11 Thread Stéphane Cerveau
Consider data as invalid if ff_wma_run_level_decode gets out with an error. It avoids an unpleasant sound distorsion. See http://trac.ffmpeg.org/ticket/9358 --- libavcodec/wmadec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/wmadec.c b/libavcodec/wmadec.c