Re: [FFmpeg-devel] [PATCH] avdevice/pulse_audio_dec: identify channel layout

2020-01-26 Thread Carl Eugen Hoyos
Am So., 26. Jan. 2020 um 21:44 Uhr schrieb Federico Simoncelli : > > On Sun, Jan 26, 2020 at 8:27 PM Carl Eugen Hoyos wrote: > > > > Am So., 26. Jan. 2020 um 18:13 Uhr schrieb Federico Simoncelli > > : > > > > > > This patch adds the attempt to identify the pulseaudio channel map and > > > when po

Re: [FFmpeg-devel] [PATCH] avdevice/pulse_audio_dec: identify channel layout

2020-01-26 Thread Federico Simoncelli
On Sun, Jan 26, 2020 at 8:27 PM Carl Eugen Hoyos wrote: > > Am So., 26. Jan. 2020 um 18:13 Uhr schrieb Federico Simoncelli > : > > > > This patch adds the attempt to identify the pulseaudio channel map and > > when possible set the relevant channel_layout parameter of the codec. > > > > The result

Re: [FFmpeg-devel] [PATCH] avdevice/pulse_audio_dec: identify channel layout

2020-01-26 Thread Carl Eugen Hoyos
Am So., 26. Jan. 2020 um 18:13 Uhr schrieb Federico Simoncelli : > > This patch adds the attempt to identify the pulseaudio channel map and > when possible set the relevant channel_layout parameter of the codec. > > The result is an improvement over the current behavior of guessing the > layout bas

Re: [FFmpeg-devel] [PATCH] avdevice/pulse_audio_dec: identify channel layout

2020-01-26 Thread Federico Simoncelli
On Sun, Jan 26, 2020 at 6:18 PM Carl Eugen Hoyos wrote: > > > Am 26.01.2020 um 17:42 schrieb Federico Simoncelli > > : > > > > On Sun, Jan 26, 2020 at 4:33 PM Carl Eugen Hoyos > > wrote: > >> Can you confirm that with the existing code, user could set the > >> channel_layout > >> for everything

Re: [FFmpeg-devel] [PATCH] avdevice/pulse_audio_dec: identify channel layout

2020-01-26 Thread Carl Eugen Hoyos
> Am 26.01.2020 um 17:42 schrieb Federico Simoncelli > : > > On Sun, Jan 26, 2020 at 4:33 PM Carl Eugen Hoyos > wrote: >> Can you confirm that with the existing code, user could set the >> channel_layout >> for everything >= 3 channels? Does this still work after your patch? > > Hi Carl, than

[FFmpeg-devel] [PATCH] avdevice/pulse_audio_dec: identify channel layout

2020-01-26 Thread Federico Simoncelli
This patch adds the attempt to identify the pulseaudio channel map and when possible set the relevant channel_layout parameter of the codec. The result is an improvement over the current behavior of guessing the layout based on the number of channels (for more information see guess_layout_max). --

Re: [FFmpeg-devel] [PATCH] avdevice/pulse_audio_dec: identify channel layout

2020-01-26 Thread Federico Simoncelli
On Sun, Jan 26, 2020 at 4:33 PM Carl Eugen Hoyos wrote: > Can you confirm that with the existing code, user could set the > channel_layout > for everything >= 3 channels? Does this still work after your patch? > > Carl Eugen Hi Carl, thanks for asking, actually I caught a segfault with >= 3 chann

Re: [FFmpeg-devel] [PATCH] avdevice/pulse_audio_dec: identify channel layout

2020-01-26 Thread Carl Eugen Hoyos
Am So., 26. Jan. 2020 um 16:23 Uhr schrieb Federico Simoncelli : > > This patch adds the attempt to identify the pulseaudio channel map and > when possible set the relevant channel_layout parameter of the codec. > > The result is an improvement over the current behavior of guessing the > layout bas

[FFmpeg-devel] [PATCH] avdevice/pulse_audio_dec: identify channel layout

2020-01-26 Thread Federico Simoncelli
This patch adds the attempt to identify the pulseaudio channel map and when possible set the relevant channel_layout parameter of the codec. The result is an improvement over the current behavior of guessing the layout based on the number of channels (for more information see guess_layout_max). --