Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Ashish Pratap Singh
thanks. On Sun, Jul 16, 2017 at 9:38 PM, Matt Oliver wrote: > On 17 July 2017 at 01:12, Derek Buitenhuis > wrote: > > > On 7/16/2017 3:15 PM, Matt Oliver wrote: > > > Im getting the same error. The patch had an error in it as this line is > > > wrong: > > > +vmaf_filter_deps="libvmaf" > > > > >

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Matt Oliver
On 17 July 2017 at 01:12, Derek Buitenhuis wrote: > On 7/16/2017 3:15 PM, Matt Oliver wrote: > > Im getting the same error. The patch had an error in it as this line is > > wrong: > > +vmaf_filter_deps="libvmaf" > > > > It should be: > > +libvmaf_filter_deps="libvmaf" > > > > As the filter is reg

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Derek Buitenhuis
On 7/16/2017 4:33 PM, Ashish Pratap Singh wrote: > Hi, sorry for that. > I will open a pull request soon (to libvmaf) for the pkg-config file. Thanks! - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpe

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Ashish Pratap Singh
On Sun, Jul 16, 2017 at 6:19 PM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 7/16/2017 1:29 PM, Ronald S. Bultje wrote: > > Pushed. > > > > Ronald > > I am going to quote myself here, because it was never address, was not even > replied to, and is outright incorrect on some OSes: >

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Ashish Pratap Singh
On Sun, Jul 16, 2017 at 5:59 PM, Ronald S. Bultje wrote: > Hi, > > On Sat, Jul 15, 2017 at 12:42 PM, Ashish Singh > wrote: > >> This one changes the previous vmaf patch to libvmaf to keep it separate >> from the >> native implementation of vmaf inside ffmpeg later. >> >> Signed-off-by: Ashish Si

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Derek Buitenhuis
On 7/16/2017 3:15 PM, Matt Oliver wrote: > Im getting the same error. The patch had an error in it as this line is > wrong: > +vmaf_filter_deps="libvmaf" > > It should be: > +libvmaf_filter_deps="libvmaf" > > As the filter is registered as libvmaf_filter not vmaf_filter in > allfilters.cpp I've

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Moritz Barsnick
On Mon, Jul 17, 2017 at 00:15:19 +1000, Matt Oliver wrote: > Currently this is breaking for me until this gets fixed It's breaking for most everyone, fate is red with "error compiling": http://fate.ffmpeg.org/?sort=descdate E.g. http://fate.ffmpeg.org/log.cgi?time=20170716125737&log=compile&slot=

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Matt Oliver
On 16 July 2017 at 23:01, Henrik Gramner wrote: > `./configure && make` results in "libavfilter/vf_libvmaf.c:29:21: > fatal error: libvmaf.h: No such file or directory". > > I don't have libvmaf installed, but it configures it as enabled and > detects it as installed anyway. Im getting the same

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Derek Buitenhuis
On 7/16/2017 2:35 PM, Ronald S. Bultje wrote: > I tested on OSX and it works fine. I'm OK with pkg-config, but since > libvmaf doesn't currently have one, we cannot rely on it. It will work fine (but link to libstdc++ unnecessarily) if you have build libvmaf as a shared library, but it will fail a

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Ronald S. Bultje
Hi, On Sun, Jul 16, 2017 at 8:49 AM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 7/16/2017 1:29 PM, Ronald S. Bultje wrote: > > Pushed. > > > > Ronald > > I am going to quote myself here, because it was never address, was not even > replied to, and is outright incorrect on some OSe

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Henrik Gramner
`./configure && make` results in "libavfilter/vf_libvmaf.c:29:21: fatal error: libvmaf.h: No such file or directory". I don't have libvmaf installed, but it configures it as enabled and detects it as installed anyway. ___ ffmpeg-devel mailing list ffmpeg

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Nicolas George
L'octidi 28 messidor, an CCXXV, Derek Buitenhuis a écrit : > Students should learn to reply to reviews instead of sending new patches > with no changelog and having them pushed anyway. Hear, hear. But a small correction: "students should learn" -> "mentors should teach". Regards, -- Nicolas

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Derek Buitenhuis
On 7/16/2017 1:49 PM, Derek Buitenhuis wrote: > Students should learn to reply to reviews instead of sending new patches > with no changelog and having them pushed anyway. Furthermore: Missing a version bump. - Derek ___ ffmpeg-devel mailing list ffmpeg

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Derek Buitenhuis
On 7/16/2017 1:29 PM, Ronald S. Bultje wrote: > Pushed. > > Ronald I am going to quote myself here, because it was never address, was not even replied to, and is outright incorrect on some OSes: >> +enabled libvmaf && { check_lib libvmaf "libvmaf.h" "compute_vmaf" >> -lvmaf -lstdc++ -

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Ronald S. Bultje
Hi, On Sat, Jul 15, 2017 at 12:42 PM, Ashish Singh wrote: > This one changes the previous vmaf patch to libvmaf to keep it separate > from the > native implementation of vmaf inside ffmpeg later. > > Signed-off-by: Ashish Singh > --- > Changelog| 1 + > configure

[FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-15 Thread Ashish Singh
This one changes the previous vmaf patch to libvmaf to keep it separate from the native implementation of vmaf inside ffmpeg later. Signed-off-by: Ashish Singh --- Changelog| 1 + configure| 5 + doc/filters.texi | 64 + libavfilter/Makefile