On Sat, Oct 24, 2020 at 13:32:25 +1300, Michael Keeley wrote:
> -if (memcmp(p->buf, "DHAV", 4))
> +if (memcmp(p->buf, "DHAV", 4) != 0 && memcmp(p->buf, "ZLAV", 4) != 0)
The "!= 0" isn't necessary.
> -if (!memcmp(signature, "DHAV", 4)) {
> +if (memcmp(signature, "DHAV", 4)
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf
> Of Paul B Mahol
> Sent: Saturday, 24 October 2020 9:03 pm
> To: FFmpeg development discussions and patches
> Cc: Michael Keeley
> Subject: Re: [FFmpeg-devel] [PATCH] avform
>
> On Oct 25, 2020, at 7:58 AM, Michael Keeley wrote:
>
> Hi Zhao,
>
>>> Some DVRs (e.g. D7008FH made by Zhuhai Ltd) output the same format
>> .dav file,
>>> but use ZLAV/zlav tags to delimit the packets instead of DHAV/dhav.
>>
>> Zhuhai Ltd doesn't look like the real company name. I didn't
Hi Michael,
> On Oct 24, 2020, at 8:32 AM, Michael Keeley wrote:
>
> Some DVRs (e.g. D7008FH made by Zhuhai Ltd) output the same format .dav file,
> but use ZLAV/zlav tags to delimit the packets instead of DHAV/dhav.
Zhuhai Ltd doesn't look like the real company name. I didn't find much
LGTM
On Sat, Oct 24, 2020 at 2:32 AM Michael Keeley wrote:
> Some DVRs (e.g. D7008FH made by Zhuhai Ltd) output the same format .dav
> file,
> but use ZLAV/zlav tags to delimit the packets instead of DHAV/dhav.
>
> Signed-off-by: Michael Keeley
> ---
> Changelog | 1 +
>
Some DVRs (e.g. D7008FH made by Zhuhai Ltd) output the same format .dav file,
but use ZLAV/zlav tags to delimit the packets instead of DHAV/dhav.
Signed-off-by: Michael Keeley
---
Changelog | 1 +
libavformat/dhav.c| 31 ++-
libavformat/version.h |
