Re: [FFmpeg-devel] [PATCH] avformat/mov: adjust skip_samples according to seek timestamp

2021-01-09 Thread Marton Balint
On Wed, 6 Jan 2021, Matthieu Bouron wrote: On Tue, Jan 05, 2021 at 09:56:39PM +0100, Marton Balint wrote: On Tue, 5 Jan 2021, Matthieu Bouron wrote: Could you factorize this to a function? It seems you are doing exactly the same thing here and below. New patch attached. [...] diff --

Re: [FFmpeg-devel] [PATCH] avformat/mov: adjust skip_samples according to seek timestamp

2021-01-06 Thread Matthieu Bouron
On Tue, Jan 05, 2021 at 09:56:39PM +0100, Marton Balint wrote: > > On Tue, 5 Jan 2021, Matthieu Bouron wrote: > > > > Could you factorize this to a function? It seems you are doing exactly the > > > same thing here and below. > > > > New patch attached. > > [...] > > > diff --git a/libavformat

Re: [FFmpeg-devel] [PATCH] avformat/mov: adjust skip_samples according to seek timestamp

2021-01-05 Thread Marton Balint
On Tue, 5 Jan 2021, Matthieu Bouron wrote: Could you factorize this to a function? It seems you are doing exactly the same thing here and below. New patch attached. [...] diff --git a/libavformat/mov.c b/libavformat/mov.c index c6a2d9c388d..e6d0de38c6f 100644 --- a/libavformat/mov.c +++ b

Re: [FFmpeg-devel] [PATCH] avformat/mov: adjust skip_samples according to seek timestamp

2021-01-05 Thread Matthieu Bouron
On Mon, Jan 04, 2021 at 09:04:05PM +0100, Marton Balint wrote: > > > On Mon, 2 Nov 2020, Matthieu Bouron wrote: > > > Currently skip_samples is set to start_pad if sample_time is lesser or > > equal to 0. This can cause issues if the stream starts with packets that > > have negative pts. Calling

Re: [FFmpeg-devel] [PATCH] avformat/mov: adjust skip_samples according to seek timestamp

2021-01-04 Thread Marton Balint
On Mon, 2 Nov 2020, Matthieu Bouron wrote: Currently skip_samples is set to start_pad if sample_time is lesser or equal to 0. This can cause issues if the stream starts with packets that have negative pts. Calling avformat_seek_file() with ts set to 0 on such streams makes the mov demuxer retu

Re: [FFmpeg-devel] [PATCH] avformat/mov: adjust skip_samples according to seek timestamp

2021-01-04 Thread Matthieu Bouron
On Mon, Nov 23, 2020 at 05:43:06PM +0100, Matthieu Bouron wrote: > On Tue, Nov 17, 2020 at 02:18:46PM +0100, Matthieu Bouron wrote: > > On Mon, Nov 09, 2020 at 06:26:46PM +0100, Matthieu Bouron wrote: > > > On Mon, Nov 02, 2020 at 12:42:19PM +0100, Matthieu Bouron wrote: > > > > Currently skip_samp

Re: [FFmpeg-devel] [PATCH] avformat/mov: adjust skip_samples according to seek timestamp

2020-11-23 Thread Matthieu Bouron
On Tue, Nov 17, 2020 at 02:18:46PM +0100, Matthieu Bouron wrote: > On Mon, Nov 09, 2020 at 06:26:46PM +0100, Matthieu Bouron wrote: > > On Mon, Nov 02, 2020 at 12:42:19PM +0100, Matthieu Bouron wrote: > > > Currently skip_samples is set to start_pad if sample_time is lesser or > > > equal to 0. Thi

Re: [FFmpeg-devel] [PATCH] avformat/mov: adjust skip_samples according to seek timestamp

2020-11-17 Thread Matthieu Bouron
On Mon, Nov 09, 2020 at 06:26:46PM +0100, Matthieu Bouron wrote: > On Mon, Nov 02, 2020 at 12:42:19PM +0100, Matthieu Bouron wrote: > > Currently skip_samples is set to start_pad if sample_time is lesser or > > equal to 0. This can cause issues if the stream starts with packets that > > have negati

Re: [FFmpeg-devel] [PATCH] avformat/mov: adjust skip_samples according to seek timestamp

2020-11-09 Thread Matthieu Bouron
On Mon, Nov 02, 2020 at 12:42:19PM +0100, Matthieu Bouron wrote: > Currently skip_samples is set to start_pad if sample_time is lesser or > equal to 0. This can cause issues if the stream starts with packets that > have negative pts. Calling avformat_seek_file() with ts set to 0 on such > streams m

[FFmpeg-devel] [PATCH] avformat/mov: adjust skip_samples according to seek timestamp

2020-11-02 Thread Matthieu Bouron
Currently skip_samples is set to start_pad if sample_time is lesser or equal to 0. This can cause issues if the stream starts with packets that have negative pts. Calling avformat_seek_file() with ts set to 0 on such streams makes the mov demuxer return the right corresponding packets (near the 0 t