Re: [FFmpeg-devel] [PATCH] avformat/mov: fix integer overflow

2015-10-12 Thread Ganesh Ajjanagadde
On Mon, Oct 12, 2015 at 12:43 PM, Michael Niedermayer wrote: > On Sat, Oct 10, 2015 at 01:51:10PM -0400, Ganesh Ajjanagadde wrote: >> Partially fixes Ticket 4727. >> >> -duration is not a safe expression, since duration can be INT_MIN. >> One might ask how it can become INT_MIN. >> Although it is

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix integer overflow

2015-10-12 Thread Michael Niedermayer
On Sat, Oct 10, 2015 at 01:51:10PM -0400, Ganesh Ajjanagadde wrote: > Partially fixes Ticket 4727. > > -duration is not a safe expression, since duration can be INT_MIN. > One might ask how it can become INT_MIN. > Although it is true that line 2574 is no longer reached with INT_MIN due > to commi

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix integer overflow

2015-10-12 Thread Ganesh Ajjanagadde
On Sat, Oct 10, 2015 at 1:51 PM, Ganesh Ajjanagadde wrote: > Partially fixes Ticket 4727. > > -duration is not a safe expression, since duration can be INT_MIN. > One might ask how it can become INT_MIN. > Although it is true that line 2574 is no longer reached with INT_MIN due > to commit 053e80f

[FFmpeg-devel] [PATCH] avformat/mov: fix integer overflow

2015-10-10 Thread Ganesh Ajjanagadde
Partially fixes Ticket 4727. -duration is not a safe expression, since duration can be INT_MIN. One might ask how it can become INT_MIN. Although it is true that line 2574 is no longer reached with INT_MIN due to commit 053e80f6eaf8d87521fe58ea96886b6ee0bbe59d (which fixed another integer overflow