On Tue, Feb 5, 2019 at 4:33 PM Niki Bowe wrote:
> Hi Carl.
> You are of course correct.
> Attached replacement patch.
>
>
> On Mon, Feb 4, 2019 at 6:24 PM Carl Eugen Hoyos
> wrote:
>
>> 2019-02-05 3:11 GMT+01:00, Nikolas Bowe :
>>
>> > +if (mov->tracks[i].eac3_priv)
>> > +
Hi Carl.
You are of course correct.
Attached replacement patch.
On Mon, Feb 4, 2019 at 6:24 PM Carl Eugen Hoyos wrote:
> 2019-02-05 3:11 GMT+01:00, Nikolas Bowe :
>
> > +if (mov->tracks[i].eac3_priv)
> > +av_freep(>tracks[i].eac3_priv);
>
> I would have expected that the
2019-02-05 3:11 GMT+01:00, Nikolas Bowe :
> +if (mov->tracks[i].eac3_priv)
> +av_freep(>tracks[i].eac3_priv);
I would have expected that the if() is unneeded, no?
Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
When using delay_moov mov_write_moov_tag gets called multiple times. Therefore
we need to keep eac3_priv around for subsequent calls.
Signed-off-by: Nikolas Bowe
---
libavformat/movenc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavformat/movenc.c
