Re: [FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable

2018-08-18 Thread Thilo Borgmann
Am 17.08.18 um 14:51 schrieb Carl Eugen Hoyos: > 2018-08-17 14:36 GMT+02:00, Hendrik Leppkes : >> On Fri, Aug 17, 2018 at 12:05 PM Paweł Wegner >> wrote: >>> >>> Yes, it will work. >>> >>> Fixes: runtime error: passing uninitialized value to FreeContextBuffer >>> causes a crash >>> >>>

Re: [FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable

2018-08-17 Thread Carl Eugen Hoyos
2018-08-17 14:36 GMT+02:00, Hendrik Leppkes : > On Fri, Aug 17, 2018 at 12:05 PM Paweł Wegner > wrote: >> >> Yes, it will work. >> >> Fixes: runtime error: passing uninitialized value to FreeContextBuffer >> causes a crash >> >> Signed-off-by: Paweł Wegner >> --- >> libavformat/tls_schannel.c |

Re: [FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable

2018-08-17 Thread Hendrik Leppkes
On Fri, Aug 17, 2018 at 12:05 PM Paweł Wegner wrote: > > Yes, it will work. > > Fixes: runtime error: passing uninitialized value to FreeContextBuffer > causes a crash > > Signed-off-by: Paweł Wegner > --- > libavformat/tls_schannel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable

2018-08-17 Thread Paweł Wegner
Yes, it will work. Fixes: runtime error: passing uninitialized value to FreeContextBuffer causes a crash Signed-off-by: Paweł Wegner --- libavformat/tls_schannel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/tls_schannel.c b/libavformat/tls_schannel.c index

Re: [FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable

2018-08-17 Thread Paweł Wegner
Yes, this works as well. I attached fixed patch. On Fri, Aug 17, 2018 at 11:15 AM Carl Eugen Hoyos wrote: > 2018-08-03 20:28 GMT+02:00, Paweł Wegner : > > > One could copy the initialization to the top from the while loop: > > init_sec_buffer([0], SECBUFFER_TOKEN, NULL, 0); > >

Re: [FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable

2018-08-17 Thread Carl Eugen Hoyos
2018-08-03 20:28 GMT+02:00, Paweł Wegner : > One could copy the initialization to the top from the while loop: > init_sec_buffer([0], SECBUFFER_TOKEN, NULL, 0); > init_sec_buffer([1], SECBUFFER_ALERT, NULL, 0); > init_sec_buffer([2], SECBUFFER_EMPTY, NULL, 0); >

Re: [FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable

2018-08-16 Thread Paweł Wegner
Could someone merge it? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable

2018-08-03 Thread Paweł Wegner
One could copy the initialization to the top from the while loop: init_sec_buffer([0], SECBUFFER_TOKEN, NULL, 0); init_sec_buffer([1], SECBUFFER_ALERT, NULL, 0); init_sec_buffer([2], SECBUFFER_EMPTY, NULL, 0); init_sec_buffer_desc(_desc, outbuf, 3); But memset is shorter. Current code

Re: [FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable

2018-08-03 Thread Paweł Wegner
One could copy the initialization to the top from the while loop: init_sec_buffer([0], SECBUFFER_TOKEN, NULL, 0); init_sec_buffer([1], SECBUFFER_ALERT, NULL, 0); init_sec_buffer([2], SECBUFFER_EMPTY, NULL, 0); init_sec_buffer_desc(_desc, outbuf, 3); But memset is shorter. Current code

Re: [FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable

2018-08-02 Thread Carl Eugen Hoyos
2018-08-02 20:46 GMT+02:00, Paweł Wegner : > Fixes: runtime error: passing uninitialized value to FreeContextBuffer > causes a crash > --- > libavformat/tls_schannel.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/tls_schannel.c b/libavformat/tls_schannel.c > index

[FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable

2018-08-02 Thread Paweł Wegner
Fixes: runtime error: passing uninitialized value to FreeContextBuffer causes a crash Signed-off-by: Paweł Wegner --- libavformat/tls_schannel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/tls_schannel.c b/libavformat/tls_schannel.c index f41b007773..6b51c1f3dc 100644 ---

[FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable

2018-08-02 Thread Paweł Wegner
Fixes: runtime error: passing uninitialized value to FreeContextBuffer causes a crash --- libavformat/tls_schannel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/tls_schannel.c b/libavformat/tls_schannel.c index 065dccb..6953008 100644 --- a/libavformat/tls_schannel.c +++