Re: [FFmpeg-devel] [PATCH] doc/developper: always use braces for statements

2019-08-07 Thread Nicolas George
Moritz Barsnick (12019-08-07): > On Wed, Aug 07, 2019 at 00:14:06 +0200, Alexander Strasser wrote: > > Nicolas, changes to the coding style should be discussed and not > > be tunneled through documentation patches. Though I don't think > > the latter was the intention of the OP. > > It was probabl

Re: [FFmpeg-devel] [PATCH] doc/developper: always use braces for statements

2019-08-07 Thread Moritz Barsnick
On Wed, Aug 07, 2019 at 00:14:06 +0200, Alexander Strasser wrote: > Nicolas, changes to the coding style should be discussed and not > be tunneled through documentation patches. Though I don't think > the latter was the intention of the OP. It was probably caused by different reviews: - "Please re

Re: [FFmpeg-devel] [PATCH] doc/developper: always use braces for statements

2019-08-06 Thread Alexander Strasser
On 2019-08-06 22:51 +0200, Nicolas George wrote: > Tomas Härdin (12019-08-06): > > I think they should. See > > Documenting the coding standard and changing it are different matters. I guess a change was intended, because it should be fairly obvious that in the current code base the described styl

Re: [FFmpeg-devel] [PATCH] doc/developper: always use braces for statements

2019-08-06 Thread Nicolas George
Tomas Härdin (12019-08-06): > I think they should. See Documenting the coding standard and changing it are different matters. > https://www.imperialviolet.org/2014/02/22/applebug.html test_warn.c: In function ‘test’: test_warn.c:6:5: warning: this ‘if’ clause does not guard... [-Wmisleading-in

Re: [FFmpeg-devel] [PATCH] doc/developper: always use braces for statements

2019-08-06 Thread Tomas Härdin
tis 2019-08-06 klockan 18:33 +0200 skrev Nicolas George: > Nicolas Gaullier (12019-08-06): > > --- > > doc/developer.texi | 8 > > 1 file changed, 8 insertions(+) > > > > diff --git a/doc/developer.texi b/doc/developer.texi > > index 5c342c9106..1e95768364 100644 > > --- a/doc/developer.

Re: [FFmpeg-devel] [PATCH] doc/developper: always use braces for statements

2019-08-06 Thread Lynne
Aug 6, 2019, 5:33 PM by geo...@nsup.org: > Nicolas Gaullier (12019-08-06): > >> --- >> doc/developer.texi | 8 >> 1 file changed, 8 insertions(+) >> >> diff --git a/doc/developer.texi b/doc/developer.texi >> index 5c342c9106..1e95768364 100644 >> --- a/doc/developer.texi >> +++ b/doc/dev

Re: [FFmpeg-devel] [PATCH] doc/developper: always use braces for statements

2019-08-06 Thread Nicolas George
Nicolas Gaullier (12019-08-06): > --- > doc/developer.texi | 8 > 1 file changed, 8 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index 5c342c9106..1e95768364 100644 > --- a/doc/developer.texi > +++ b/doc/developer.texi > @@ -213,6 +213,14 @@ please use av_log(

[FFmpeg-devel] [PATCH] doc/developper: always use braces for statements

2019-08-06 Thread Nicolas Gaullier
--- doc/developer.texi | 8 1 file changed, 8 insertions(+) diff --git a/doc/developer.texi b/doc/developer.texi index 5c342c9106..1e95768364 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -213,6 +213,14 @@ please use av_log() instead. @item Casts should be used only when