Re: [FFmpeg-devel] [PATCH] fate: allow temp files for passed test to be kept

2018-07-10 Thread Gyan Doshi
On 10-07-2018 05:40 PM, Carl Eugen Hoyos wrote: Shouldn't this be -1 for keep if fail, 0 for always delete, 1 for keep? $keep is checked only when $err = 0 i.e. a) passed test or b) failed test and GEN != no In the 2nd case, since user has decided to overwrite existing ref, I assume the

Re: [FFmpeg-devel] [PATCH] fate: allow temp files for passed test to be kept

2018-07-10 Thread Carl Eugen Hoyos
2018-07-06 11:35 GMT+02:00, Gyan Doshi : > +@item KEEP > +Set to @samp{1} to keep temp files generated by fate test(s) when test is > successful. > +Default is @samp{0}, which removes these files. Files are always kept when a > test > +fails. Sorry for the late comment: Shouldn't this be -1

Re: [FFmpeg-devel] [PATCH] fate: allow temp files for passed test to be kept

2018-07-09 Thread Gyan Doshi
On 09-07-2018 10:06 AM, Gyan Doshi wrote: Will push tonight if no objections. Pushed as 0bd48ab2d9e463b75ef52c0eaa0cc00c4c385cce ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] fate: allow temp files for passed test to be kept

2018-07-08 Thread Gyan Doshi
On 08-07-2018 11:27 PM, Gyan Doshi wrote: Ping. Will push tonight if no objections. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] fate: allow temp files for passed test to be kept

2018-07-08 Thread Gyan Doshi
Ping. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] fate: allow temp files for passed test to be kept

2018-07-06 Thread Gyan Doshi
From 18351747e460d52939d54bdf20364e4156852034 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Fri, 6 Jul 2018 14:53:33 +0530 Subject: [PATCH] fate: allow temp files for passed test to be kept Set make variable KEEP to non-zero value to preserve temp files when a test has passed. Helpful in