Re: [FFmpeg-devel] [PATCH] fftools: Accept more negative prefixes

2020-08-26 Thread Moritz Barsnick
On Sat, Aug 22, 2020 at 21:55:21 +0100, Mark Thompson wrote: > > Without checking in more detail: Wouldn't this break the > > "-noise_reduction", "-non_deterministic" and "-non_linear_quant" > > options? > > The intent is to extend what already happens - given an argument like > "-nougat", it

Re: [FFmpeg-devel] [PATCH] fftools: Accept more negative prefixes

2020-08-22 Thread Mark Thompson
On 21/08/2020 06:49, Moritz Barsnick wrote: On Thu, Aug 20, 2020 at 22:49:16 +0100, Mark Thompson wrote: With this patch, -disable_auto_conversion_filters does what you want. [...] +if (!po->name) { +/* Try to match a boolean option with a negative prefix. */ +for (int i

Re: [FFmpeg-devel] [PATCH] fftools: Accept more negative prefixes

2020-08-20 Thread Moritz Barsnick
On Thu, Aug 20, 2020 at 22:49:16 +0100, Mark Thompson wrote: > With this patch, -disable_auto_conversion_filters does what you want. [...] > +if (!po->name) { > +/* Try to match a boolean option with a negative prefix. */ > +for (int i = 0; i <

[FFmpeg-devel] [PATCH] fftools: Accept more negative prefixes

2020-08-20 Thread Mark Thompson
In addition to "no", also allow "no_", "disable" and "disable_". --- On 20/08/2020 18:49, Nicolas George wrote: Alexander Strasser (12020-08-17): Here are some suggestions in no particular order: * auto_conversion_filters (from Marton) I can be ok with this one. I really dislike boolean