Re: [FFmpeg-devel] [PATCH] jvdec: avoid unsized overflow in comparison

2015-11-07 Thread Andreas Cadhalpun
low. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/jvdec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > lgtm Pushed... On 07.11.2015 06:19, Timothy Gu wrote: > On Fri, Nov 06, 2015 at 09:11:40PM +0100, Andreas Cadhalpun

Re: [FFmpeg-devel] [PATCH] jvdec: avoid unsized overflow in comparison

2015-11-06 Thread Timothy Gu
On Fri, Nov 06, 2015 at 09:11:40PM +0100, Andreas Cadhalpun wrote: > Subject: [FFmpeg-devel] [PATCH] jvdec: avoid unsized overflow in comparison *unsigned [...] Timothy ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mail

Re: [FFmpeg-devel] [PATCH] jvdec: avoid unsized overflow in comparison

2015-11-06 Thread Paul B Mahol
On 11/6/15, Andreas Cadhalpun wrote: > The return type of strlen is size_t, i.e. unsigned, so if pd->buf_size > is 3, the right side overflows leading to a wrong result of the > comparison and subsequently a heap buffer overflow. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/jvdec.c |

[FFmpeg-devel] [PATCH] jvdec: avoid unsized overflow in comparison

2015-11-06 Thread Andreas Cadhalpun
The return type of strlen is size_t, i.e. unsigned, so if pd->buf_size is 3, the right side overflows leading to a wrong result of the comparison and subsequently a heap buffer overflow. Signed-off-by: Andreas Cadhalpun --- libavformat/jvdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-