Re: [FFmpeg-devel] [PATCH] lavc/webp: Remove frame threading

2023-10-23 Thread Thilo Borgmann via ffmpeg-devel
Am 22.10.23 um 16:30 schrieb Andreas Rheinhardt: Thilo Borgmann via ffmpeg-devel: Revealed by the patch to support animated webp, the current frame threading implementation contains a data race. No, it doesn't: The current implementation does not call ff_thread_finish_setup() in vp8.c for

Re: [FFmpeg-devel] [PATCH] lavc/webp: Remove frame threading

2023-10-22 Thread Andreas Rheinhardt
Thilo Borgmann via ffmpeg-devel: > Revealed by the patch to support animated webp, the current > frame threading implementation contains a data race. No, it doesn't: The current implementation does not call ff_thread_finish_setup() in vp8.c for webp: if

[FFmpeg-devel] [PATCH] lavc/webp: Remove frame threading

2023-10-22 Thread Thilo Borgmann via ffmpeg-devel
Revealed by the patch to support animated webp, the current frame threading implementation contains a data race. vp8_lossy_decode_frame() calls ff_vp8_decode_frame() wich calls ff_thread_finish_setup() to sync its internal slice threading. The race is happens because vp8_lossy_decode_frame() has