Re: [FFmpeg-devel] [PATCH] lavf/flvdec: normalize exporting date metadata

2021-05-19 Thread Alexander Strasser
On 2021-05-16 21:18 +0200, Anton Khirnov wrote: > Quoting Alexander Strasser (2021-05-15 20:20:30) [...] > > > > Returning to the code I quoted before now and stating my > > understanding of if now. > > > > def write__AMF_date(time) > > write__UI8 11 > > write [(time.to_f *

Re: [FFmpeg-devel] [PATCH] lavf/flvdec: normalize exporting date metadata

2021-05-16 Thread Anton Khirnov
Quoting Alexander Strasser (2021-05-15 20:20:30) > Hi Anton! > > On 2021-05-14 10:09 +0200, Anton Khirnov wrote: > > Quoting Alexander Strasser (2021-05-12 01:04:28) > > > > > > If the timezone data of an AMF 0 date type is non-zero, include that > > > information as UTC offset in hours and

Re: [FFmpeg-devel] [PATCH] lavf/flvdec: normalize exporting date metadata

2021-05-15 Thread Alexander Strasser
Hi Anton! On 2021-05-14 10:09 +0200, Anton Khirnov wrote: > Quoting Alexander Strasser (2021-05-12 01:04:28) > > > > If the timezone data of an AMF 0 date type is non-zero, include that > > information as UTC offset in hours and minutes. > > --- > > libavformat/flvdec.c | 18 +++--- >

Re: [FFmpeg-devel] [PATCH] lavf/flvdec: normalize exporting date metadata

2021-05-14 Thread Anton Khirnov
Quoting Alexander Strasser (2021-05-12 01:04:28) > From 3fd6c8f81baacace49e0a6cc431295dc56a077bc Mon Sep 17 00:00:00 2001 > From: Alexander Strasser > Date: Wed, 12 May 2021 00:46:54 +0200 > Subject: [PATCH] lavf/flvdec: metadata date: respect timezone information if > present > > If the

Re: [FFmpeg-devel] [PATCH] lavf/flvdec: normalize exporting date metadata

2021-05-12 Thread Anton Khirnov
pushed the patch as is, since it fixes FATE Further comments can be applied on top of it later. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above,

Re: [FFmpeg-devel] [PATCH] lavf/flvdec: normalize exporting date metadata

2021-05-11 Thread Alexander Strasser
On 2021-05-11 17:51 +0200, Anton Khirnov wrote: > Quoting Alexander Strasser (2021-05-10 15:35:02) > > On 2021-05-10 10:22 +0200, Anton Khirnov wrote: > > > Export them in UTC, not the local timezone. This way the output is > > > the same everywhere. The timezone information stored in the file is

Re: [FFmpeg-devel] [PATCH] lavf/flvdec: normalize exporting date metadata

2021-05-11 Thread Anton Khirnov
Quoting Marton Balint (2021-05-10 19:36:59) > > > On Mon, 10 May 2021, Anton Khirnov wrote: > > > Export them in UTC, not the local timezone. This way the output is > > the same everywhere. The timezone information stored in the file is > > still ignored, since there seems to be no simple way

Re: [FFmpeg-devel] [PATCH] lavf/flvdec: normalize exporting date metadata

2021-05-11 Thread Anton Khirnov
Quoting Alexander Strasser (2021-05-10 15:35:02) > On 2021-05-10 10:22 +0200, Anton Khirnov wrote: > > Export them in UTC, not the local timezone. This way the output is > > the same everywhere. The timezone information stored in the file is > > still ignored, since there seems to be no simple way

Re: [FFmpeg-devel] [PATCH] lavf/flvdec: normalize exporting date metadata

2021-05-10 Thread Marton Balint
On Mon, 10 May 2021, Anton Khirnov wrote: Export them in UTC, not the local timezone. This way the output is the same everywhere. The timezone information stored in the file is still ignored, since there seems to be no simple way to export it correctly. Format them according to ISO 8601,

Re: [FFmpeg-devel] [PATCH] lavf/flvdec: normalize exporting date metadata

2021-05-10 Thread Alexander Strasser
On 2021-05-10 10:22 +0200, Anton Khirnov wrote: > Export them in UTC, not the local timezone. This way the output is > the same everywhere. The timezone information stored in the file is > still ignored, since there seems to be no simple way to export it > correctly. > > Format them according to

[FFmpeg-devel] [PATCH] lavf/flvdec: normalize exporting date metadata

2021-05-10 Thread Anton Khirnov
Export them in UTC, not the local timezone. This way the output is the same everywhere. The timezone information stored in the file is still ignored, since there seems to be no simple way to export it correctly. Format them according to ISO 8601, which we generally use for exporting dates. --- If