Re: [FFmpeg-devel] [PATCH] lavf/matroskaenc: sort options by name

2024-04-11 Thread Paul B Mahol
On Wed, Apr 10, 2024 at 11:08 AM Stefano Sabatini wrote: > On date Sunday 2024-04-07 16:01:27 +0800, Zhao Zhili wrote: > > > > > On Apr 7, 2024, at 14:16, Anton Khirnov wrote: > > > > > > Quoting Andreas Rheinhardt (2024-04-06 13:25:49) > > >> See >

Re: [FFmpeg-devel] [PATCH] lavf/matroskaenc: sort options by name

2024-04-10 Thread Stefano Sabatini
On date Sunday 2024-04-07 16:01:27 +0800, Zhao Zhili wrote: > > > On Apr 7, 2024, at 14:16, Anton Khirnov wrote: > > > > Quoting Andreas Rheinhardt (2024-04-06 13:25:49) > >> See https://ffmpeg.org/pipermail/ffmpeg-devel/2024-February/320849.html > >> Additionally I do not agree that sorting

Re: [FFmpeg-devel] [PATCH] lavf/matroskaenc: sort options by name

2024-04-07 Thread Zhao Zhili
> On Apr 7, 2024, at 14:16, Anton Khirnov wrote: > > Quoting Andreas Rheinhardt (2024-04-06 13:25:49) >> See https://ffmpeg.org/pipermail/ffmpeg-devel/2024-February/320849.html >> Additionally I do not agree that sorting options by name is the best >> way; it should be sorted by what are

Re: [FFmpeg-devel] [PATCH] lavf/matroskaenc: sort options by name

2024-04-07 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-04-06 13:25:49) > See https://ffmpeg.org/pipermail/ffmpeg-devel/2024-February/320849.html > Additionally I do not agree that sorting options by name is the best > way; it should be sorted by what are (believed to be) the most commonly > used options. +1 -- Anton

Re: [FFmpeg-devel] [PATCH] lavf/matroskaenc: sort options by name

2024-04-06 Thread Stefano Sabatini
On date Saturday 2024-04-06 13:25:49 +0200, Andreas Rheinhardt wrote: > Stefano Sabatini: > > --- > > libavformat/matroskaenc.c | 12 ++-- > > 1 file changed, 6 insertions(+), 6 deletions(-) > > [...] > See https://ffmpeg.org/pipermail/ffmpeg-devel/2024-February/320849.html >

Re: [FFmpeg-devel] [PATCH] lavf/matroskaenc: sort options by name

2024-04-06 Thread Andreas Rheinhardt
Stefano Sabatini: > --- > libavformat/matroskaenc.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c > index 566e9f4981..8ebe6e4334 100644 > --- a/libavformat/matroskaenc.c > +++

[FFmpeg-devel] [PATCH] lavf/matroskaenc: sort options by name

2024-04-06 Thread Stefano Sabatini
--- libavformat/matroskaenc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 566e9f4981..8ebe6e4334 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -3500,20 +3500,20 @@ static