Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2015-01-13 Thread Stefano Sabatini
On date Saturday 2015-01-10 01:46:38 +0530, Arwa Arif encoded: On Fri, Jan 9, 2015 at 10:07 PM, Stefano Sabatini stefa...@gmail.com [...] From 2367adb44a62e67427f0de5af8047a0008f3b0f8 Mon Sep 17 00:00:00 2001 From: Arwa Arif arwaarif1...@gmail.com Date: Sat, 10 Jan 2015 01:21:14 +0530

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2015-01-09 Thread Michael Niedermayer
On Sat, Jan 10, 2015 at 01:46:38AM +0530, arwa arif wrote: On Fri, Jan 9, 2015 at 10:07 PM, Stefano Sabatini stefa...@gmail.com wrote: On date Wednesday 2015-01-07 19:14:49 +0530, arwa arif encoded: [...] From 2676f37a204b48bdbb2e24359b6a85598a8c021b Mon Sep 17 00:00:00 2001 From:

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2015-01-09 Thread Stefano Sabatini
On date Friday 2015-01-09 15:00:58 +0100, Michael Niedermayer encoded: On Fri, Jan 09, 2015 at 12:08:21PM +0530, arwa arif wrote: [...] They are using mp=pp7=0:0 as default. But, in documentation they have mentioned that medium thresholding (mp=pp7=0:2) is default. What should I follow?

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2015-01-09 Thread Stefano Sabatini
On date Wednesday 2015-01-07 19:14:49 +0530, arwa arif encoded: [...] From 2676f37a204b48bdbb2e24359b6a85598a8c021b Mon Sep 17 00:00:00 2001 From: Arwa Arif arwaarif1...@gmail.com Date: Thu, 25 Dec 2014 09:50:24 +0530 Subject: [PATCH] lavfi: port mp=pp7 to avfilter TODO: modify version.h,

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2015-01-09 Thread Michael Niedermayer
On Fri, Jan 09, 2015 at 12:08:21PM +0530, arwa arif wrote: On Fri, Jan 9, 2015 at 12:27 AM, Michael Niedermayer michae...@gmx.at wrote: On Thu, Jan 08, 2015 at 04:03:18PM +0100, Michael Niedermayer wrote: On Thu, Jan 08, 2015 at 07:32:51PM +0530, arwa arif wrote: On Thu, Jan 8, 2015

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2015-01-08 Thread arwa arif
On Fri, Jan 9, 2015 at 12:27 AM, Michael Niedermayer michae...@gmx.at wrote: On Thu, Jan 08, 2015 at 04:03:18PM +0100, Michael Niedermayer wrote: On Thu, Jan 08, 2015 at 07:32:51PM +0530, arwa arif wrote: On Thu, Jan 8, 2015 at 7:23 PM, Michael Niedermayer michae...@gmx.at wrote:

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2015-01-08 Thread arwa arif
On Wed, Jan 7, 2015 at 9:46 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Jan 07, 2015 at 03:42:16PM +0100, Stefano Sabatini wrote: On date Wednesday 2015-01-07 19:14:49 +0530, arwa arif encoded: Keep in mind that the difference may be due to the QP information

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2015-01-08 Thread Michael Niedermayer
On Thu, Jan 08, 2015 at 01:43:24PM +0530, arwa arif wrote: On Wed, Jan 7, 2015 at 9:46 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Jan 07, 2015 at 03:42:16PM +0100, Stefano Sabatini wrote: On date Wednesday 2015-01-07 19:14:49 +0530, arwa arif encoded: Keep in

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2015-01-08 Thread arwa arif
On Thu, Jan 8, 2015 at 7:23 PM, Michael Niedermayer michae...@gmx.at wrote: On Thu, Jan 08, 2015 at 01:43:24PM +0530, arwa arif wrote: On Wed, Jan 7, 2015 at 9:46 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Jan 07, 2015 at 03:42:16PM +0100, Stefano Sabatini wrote: On

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2015-01-08 Thread Michael Niedermayer
On Thu, Jan 08, 2015 at 07:32:51PM +0530, arwa arif wrote: On Thu, Jan 8, 2015 at 7:23 PM, Michael Niedermayer michae...@gmx.at wrote: On Thu, Jan 08, 2015 at 01:43:24PM +0530, arwa arif wrote: On Wed, Jan 7, 2015 at 9:46 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed,

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2015-01-08 Thread Michael Niedermayer
On Thu, Jan 08, 2015 at 04:03:18PM +0100, Michael Niedermayer wrote: On Thu, Jan 08, 2015 at 07:32:51PM +0530, arwa arif wrote: On Thu, Jan 8, 2015 at 7:23 PM, Michael Niedermayer michae...@gmx.at wrote: On Thu, Jan 08, 2015 at 01:43:24PM +0530, arwa arif wrote: On Wed, Jan 7, 2015

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2015-01-07 Thread Stefano Sabatini
On date Wednesday 2015-01-07 19:14:49 +0530, arwa arif encoded: Keep in mind that the difference may be due to the QP information missing in mp=pp7. So you should focus on that (try to reset/disable qp processing in pp7 and see if it works the same as mp=pp7). For qp=0, the results

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2015-01-07 Thread arwa arif
Keep in mind that the difference may be due to the QP information missing in mp=pp7. So you should focus on that (try to reset/disable qp processing in pp7 and see if it works the same as mp=pp7). For qp=0, the results are bitexact. I am not able to figure out how do I take care of the non

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2015-01-07 Thread Michael Niedermayer
On Wed, Jan 07, 2015 at 03:42:16PM +0100, Stefano Sabatini wrote: On date Wednesday 2015-01-07 19:14:49 +0530, arwa arif encoded: Keep in mind that the difference may be due to the QP information missing in mp=pp7. So you should focus on that (try to reset/disable qp processing in

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2015-01-05 Thread Stefano Sabatini
On date Monday 2014-12-29 10:20:26 +0100, Stefano Sabatini encoded: On date Sunday 2014-12-28 19:45:18 +0530, arwa arif encoded: [...] From ebf5f36d9e9fc80264bb605dfee5c09cbf1f10ef Mon Sep 17 00:00:00 2001 From: Arwa Arif arwaarif1...@gmail.com Date: Thu, 25 Dec 2014 09:50:24 +0530

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2014-12-29 Thread Stefano Sabatini
On date Sunday 2014-12-28 19:45:18 +0530, arwa arif encoded: [...] From ebf5f36d9e9fc80264bb605dfee5c09cbf1f10ef Mon Sep 17 00:00:00 2001 From: Arwa Arif arwaarif1...@gmail.com Date: Thu, 25 Dec 2014 09:50:24 +0530 Subject: [PATCH] lavfi: port mp=pp7 to avfilter Added use_bframe_qp in the

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2014-12-28 Thread arwa arif
Are you sure? I get this: libavfilter/filtfmts-test mp pp7 [...] INPUT[0] default: fmt:gray INPUT[0] default: fmt:yuv410p INPUT[0] default: fmt:yuv420p INPUT[0] default: fmt:yuv411p INPUT[0] default: fmt:yuv422p INPUT[0] default: fmt:yuv444p INPUT[0] default: fmt:yuvj420p INPUT[0]

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2014-12-28 Thread Michael Niedermayer
On Sun, Dec 28, 2014 at 07:45:18PM +0530, arwa arif wrote: Are you sure? I get this: libavfilter/filtfmts-test mp pp7 [...] INPUT[0] default: fmt:gray INPUT[0] default: fmt:yuv410p INPUT[0] default: fmt:yuv420p INPUT[0] default: fmt:yuv411p INPUT[0] default: fmt:yuv422p

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2014-12-27 Thread arwa arif
...] +static int query_formats(AVFilterContext *ctx) +{ +static const enum PixelFormat pix_fmts[] = { +AV_PIX_FMT_YUV444P, AV_PIX_FMT_YUV422P, +AV_PIX_FMT_YUV420P, AV_PIX_FMT_YUV411P, +AV_PIX_FMT_YUV410P, AV_PIX_FMT_YUV440P, +

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2014-12-27 Thread Michael Niedermayer
On Sat, Dec 27, 2014 at 06:07:53PM +0530, arwa arif wrote: [...] +#define OFFSET(x) offsetof(PP7Context, x) +#define FLAGS AV_OPT_FLAG_FILTERING_PARAM|AV_OPT_FLAG_VIDEO_PARAM +static const AVOption pp7_options[] = { +{ qp, force a constant quantizer parameter, OFFSET(qp),

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2014-12-27 Thread Stefano Sabatini
On date Saturday 2014-12-27 18:07:53 +0530, arwa arif encoded: ...] +static int query_formats(AVFilterContext *ctx) +{ +static const enum PixelFormat pix_fmts[] = { +AV_PIX_FMT_YUV444P, AV_PIX_FMT_YUV422P, +AV_PIX_FMT_YUV420P, AV_PIX_FMT_YUV411P,

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2014-12-25 Thread Carl Eugen Hoyos
arwa arif arwaarif1994 at gmail.com writes: +static const enum PixelFormat pix_fmts[] = { +AV_PIX_FMT_YUV444P, AV_PIX_FMT_YUV422P, +AV_PIX_FMT_YUV420P, AV_PIX_FMT_YUV411P, +AV_PIX_FMT_YUV410P, AV_PIX_FMT_YUV440P, +AV_PIX_FMT_YUVJ444P,

Re: [FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

2014-12-25 Thread Stefano Sabatini
On date Thursday 2014-12-25 21:50:03 +0530, arwa arif encoded: +#include libavutil/avassert.h +#include libavutil/imgutils.h +#include libavutil/opt.h +#include libavutil/pixdesc.h +#include internal.h +#include libavcodec/avcodec.h //for reference to FF_QSCALE_TYPE +#include