Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-25 Thread Thierry Foucu
On Wed, Oct 25, 2017 at 4:36 PM, Michael Niedermayer wrote: > On Wed, Oct 25, 2017 at 04:21:28PM -0700, Thierry Foucu wrote: > > On Wed, Oct 25, 2017 at 2:43 PM, Carl Eugen Hoyos > > wrote: > > > > > 2017-10-25 20:38 GMT+02:00 Thierry Foucu : > > > > > > > Without the patch, the decoder will ret

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-25 Thread Michael Niedermayer
On Wed, Oct 25, 2017 at 04:21:28PM -0700, Thierry Foucu wrote: > On Wed, Oct 25, 2017 at 2:43 PM, Carl Eugen Hoyos > wrote: > > > 2017-10-25 20:38 GMT+02:00 Thierry Foucu : > > > > > Without the patch, the decoder will return only 29 frames > > > > Isn't that the correct and expected output? > >

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-25 Thread Thierry Foucu
On Wed, Oct 25, 2017 at 2:43 PM, Carl Eugen Hoyos wrote: > 2017-10-25 20:38 GMT+02:00 Thierry Foucu : > > > Without the patch, the decoder will return only 29 frames > > Isn't that the correct and expected output? > Not sure what you mean by correct. There are only 29 VOP encoded, and over 1900

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-25 Thread Carl Eugen Hoyos
2017-10-25 20:38 GMT+02:00 Thierry Foucu : > Without the patch, the decoder will return only 29 frames Isn't that the correct and expected output? If you need cfr, you can request it. Once the frames are duplicated, you can't undo the file size multiplication. Carl Eugen ___

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-25 Thread Derek Buitenhuis
This time to the list properly... woops. On 10/25/2017 7:38 PM, Thierry Foucu wrote: > I tried using one of those files. > Without the patch, the decoder will return only 29 frames > With this patch, the decoder will return 1947 frames. > The time of decoding the file were the same (with or withou

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-25 Thread Thierry Foucu
On Wed, Oct 25, 2017 at 4:59 AM, Michael Niedermayer wrote: > On Tue, Oct 24, 2017 at 06:42:54PM -0700, Thierry Foucu wrote: > > Changed the return value when no VOD were encoded in Mpeg4 bistream. > > And if we do have already a decoded frames and we are not in xvid_packed > > mode, output the e

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-25 Thread Thierry Foucu
Derek, On Wed, Oct 25, 2017 at 9:43 AM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 10/25/2017 2:42 AM, Thierry Foucu wrote: > > Changed the return value when no VOD were encoded in Mpeg4 bistream. > > And if we do have already a decoded frames and we are not in xvid_packed > > mod

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-25 Thread Derek Buitenhuis
On 10/25/2017 2:42 AM, Thierry Foucu wrote: > Changed the return value when no VOD were encoded in Mpeg4 bistream. > And if we do have already a decoded frames and we are not in xvid_packed > mode, output the existing decoded frame instead of nothing. > --- > libavcodec/h263dec.c | 9 +++

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-25 Thread Michael Niedermayer
On Tue, Oct 24, 2017 at 06:42:54PM -0700, Thierry Foucu wrote: > Changed the return value when no VOD were encoded in Mpeg4 bistream. > And if we do have already a decoded frames and we are not in xvid_packed > mode, output the existing decoded frame instead of nothing. > --- > libavcodec/h263dec.

[FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-24 Thread Thierry Foucu
Changed the return value when no VOD were encoded in Mpeg4 bistream. And if we do have already a decoded frames and we are not in xvid_packed mode, output the existing decoded frame instead of nothing. --- libavcodec/h263dec.c | 9 - libavcodec/mpeg4videodec.c | 2 +- libavcodec/mpeg

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-24 Thread Thierry Foucu
Michael, what do you think of this patch? I tried to reflect what the xvid decoder does for those N_VOP frame and in case it is not packed. On Tue, Oct 24, 2017 at 6:42 PM, Thierry Foucu wrote: > Changed the return value when no VOD were encoded in Mpeg4 bistream. > And if we do have already

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-20 Thread Michael Niedermayer
On Thu, Oct 19, 2017 at 04:20:48PM -0700, Thierry Foucu wrote: > On Thu, Oct 19, 2017 at 3:43 PM, Michael Niedermayer > wrote: > > > On Thu, Oct 19, 2017 at 09:51:05AM -0700, Thierry Foucu wrote: > > > Instead of returning nothing when we detect the xvid skipped frame, we > > > could return the l

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-19 Thread Thierry Foucu
On Thu, Oct 19, 2017 at 3:43 PM, Michael Niedermayer wrote: > On Thu, Oct 19, 2017 at 09:51:05AM -0700, Thierry Foucu wrote: > > Instead of returning nothing when we detect the xvid skipped frame, we > > could return the last decoded frame, if we do have one. > > FRAME_SKIPPED is not limited to x

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-19 Thread Michael Niedermayer
On Thu, Oct 19, 2017 at 09:51:05AM -0700, Thierry Foucu wrote: > Instead of returning nothing when we detect the xvid skipped frame, we > could return the last decoded frame, if we do have one. FRAME_SKIPPED is not limited to xvid (packed frames). There are a few other pathes that return it. For

[FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-19 Thread Thierry Foucu
Instead of returning nothing when we detect the xvid skipped frame, we could return the last decoded frame, if we do have one. --- libavcodec/h263dec.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavcodec/h263dec.c b/libavcodec/h263dec.c index bcb2b08bb0..e1667bcb