Re: [FFmpeg-devel] [PATCH] libavcodec/mpegaudiodecheader.h : detect reserved mpeg id

2018-07-11 Thread Carl Eugen Hoyos
2018-07-12 0:03 GMT+02:00, Karsten Otto : > Argh, just noticed a stupid mistake - quite obviously, the check pattern > needs to be shifted too, i.e. 1<<19 instead of just 1. Luckily, it won't do > any harm, since it can never evaluate to true. > > What is the protocol in this case - Do I send a new

Re: [FFmpeg-devel] [PATCH] libavcodec/mpegaudiodecheader.h : detect reserved mpeg id

2018-07-11 Thread Karsten Otto
Argh, just noticed a stupid mistake - quite obviously, the check pattern needs to be shifted too, i.e. 1<<19 instead of just 1. Luckily, it won't do any harm, since it can never evaluate to true. What is the protocol in this case - Do I send a new version of the patch? Or another patch to the patc

Re: [FFmpeg-devel] [PATCH] libavcodec/mpegaudiodecheader.h : detect reserved mpeg id

2018-07-08 Thread Michael Niedermayer
On Sun, Jul 08, 2018 at 12:26:10PM +0200, Karsten Otto wrote: > Check the MPEG version ID for the reserved bit pattern 01, and abort the > header check in that case. This reduces the chance of misinterpreting > arbitrary data as a valid header, and prevents resulting audio artifacts. > --- > libav

[FFmpeg-devel] [PATCH] libavcodec/mpegaudiodecheader.h : detect reserved mpeg id

2018-07-08 Thread Karsten Otto
Check the MPEG version ID for the reserved bit pattern 01, and abort the header check in that case. This reduces the chance of misinterpreting arbitrary data as a valid header, and prevents resulting audio artifacts. --- libavcodec/mpegaudiodecheader.h | 3 +++ 1 file changed, 3 insertions(+) dif