Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-26 Thread wm4
On Mon, 26 Oct 2015 15:01:50 +0100 Gwenole Beauchesne wrote: > 2015-10-26 12:44 GMT+01:00 wm4 : > > On Mon, 26 Oct 2015 11:22:38 +0100 > > Gwenole Beauchesne wrote: > > > > > >> >> /** > >> >> * Hardware Accelerator identifier. > >> >> * > >> >> * @note > >> >> * A hardware accelerator can

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-26 Thread Gwenole Beauchesne
2015-10-26 12:44 GMT+01:00 wm4 : > On Mon, 26 Oct 2015 11:22:38 +0100 > Gwenole Beauchesne wrote: > > >> >> /** >> >> * Hardware Accelerator identifier. >> >> * >> >> * @note >> >> * A hardware accelerator can be device-less. This means that only the >> >> * underlying hardware resource, e.g.

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-26 Thread Sven Dueking
> -Ursprüngliche Nachricht- > Von: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] Im Auftrag > von Hendrik Leppkes > Gesendet: Donnerstag, 22. Oktober 2015 17:56 > An: FFmpeg development discussions and patches > Betreff: Re: [FFmpeg-devel] [PATCH] libavcode

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-26 Thread Hendrik Leppkes
On Mon, Oct 26, 2015 at 1:12 PM, wm4 wrote: > On Mon, 26 Oct 2015 12:56:31 +0100 > Hendrik Leppkes wrote: > >> >> > I think doing cropping as metadata would also simplify code a lot. For >> >> > example, nobody has to worry about non-mod-2 yuv420 anymore, and how it >> >> > should be handled. It'

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-26 Thread wm4
On Mon, 26 Oct 2015 12:56:31 +0100 Hendrik Leppkes wrote: > >> > I think doing cropping as metadata would also simplify code a lot. For > >> > example, nobody has to worry about non-mod-2 yuv420 anymore, and how it > >> > should be handled. It's less tricky, more correct, more efficient. > >> >

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-26 Thread Hendrik Leppkes
On Mon, Oct 26, 2015 at 12:44 PM, wm4 wrote: > On Mon, 26 Oct 2015 11:22:38 +0100 > Gwenole Beauchesne wrote: > > >> >> /** >> >> * Hardware Accelerator identifier. >> >> * >> >> * @note >> >> * A hardware accelerator can be device-less. This means that only the >> >> * underlying hardware r

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-26 Thread wm4
On Mon, 26 Oct 2015 11:22:38 +0100 Gwenole Beauchesne wrote: > >> /** > >> * Hardware Accelerator identifier. > >> * > >> * @note > >> * A hardware accelerator can be device-less. This means that only the > >> * underlying hardware resource, e.g. a Linux dma_buf handle, is being > >> * tra

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-26 Thread Gwenole Beauchesne
Hi, 2015-10-23 16:52 GMT+02:00 wm4 : > On Fri, 23 Oct 2015 16:12:07 +0200 > Gwenole Beauchesne wrote: > >> Hi, >> >> 2015-10-23 15:41 GMT+02:00 wm4 : >> > On Fri, 23 Oct 2015 14:54:56 +0200 >> > Gwenole Beauchesne wrote: >> > >> >> Hi, >> >> >> >> 2015-10-07 18:40 GMT+02:00 wm4 : >> >> > On Wed,

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-23 Thread wm4
On Fri, 23 Oct 2015 16:12:07 +0200 Gwenole Beauchesne wrote: > Hi, > > 2015-10-23 15:41 GMT+02:00 wm4 : > > On Fri, 23 Oct 2015 14:54:56 +0200 > > Gwenole Beauchesne wrote: > > > >> Hi, > >> > >> 2015-10-07 18:40 GMT+02:00 wm4 : > >> > On Wed, 7 Oct 2015 19:20:56 +0300 > >> > Ivan Uskov wr

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-23 Thread Gwenole Beauchesne
Hi, 2015-10-23 15:41 GMT+02:00 wm4 : > On Fri, 23 Oct 2015 14:54:56 +0200 > Gwenole Beauchesne wrote: > >> Hi, >> >> 2015-10-07 18:40 GMT+02:00 wm4 : >> > On Wed, 7 Oct 2015 19:20:56 +0300 >> > Ivan Uskov wrote: >> > >> >> Hello Hendrik, >> >> >> >> Wednesday, October 7, 2015, 5:58:25 PM, you wr

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-23 Thread wm4
On Fri, 23 Oct 2015 14:54:56 +0200 Gwenole Beauchesne wrote: > Hi, > > 2015-10-07 18:40 GMT+02:00 wm4 : > > On Wed, 7 Oct 2015 19:20:56 +0300 > > Ivan Uskov wrote: > > > >> Hello Hendrik, > >> > >> Wednesday, October 7, 2015, 5:58:25 PM, you wrote: > >> > >> HL> On Wed, Oct 7, 2015 at 4:41

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-23 Thread Gwenole Beauchesne
Hi, 2015-10-07 18:40 GMT+02:00 wm4 : > On Wed, 7 Oct 2015 19:20:56 +0300 > Ivan Uskov wrote: > >> Hello Hendrik, >> >> Wednesday, October 7, 2015, 5:58:25 PM, you wrote: >> >> HL> On Wed, Oct 7, 2015 at 4:41 PM, Ivan Uskov wrote: >> >> HL> Global static variables are not acceptable, sorry. >> HL

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-22 Thread Hendrik Leppkes
On Wed, Oct 14, 2015 at 11:47 AM, Hendrik Leppkes wrote: > On Wed, Oct 7, 2015 at 7:07 PM, Ivan Uskov wrote: >> Hello wm4, >> >> Wednesday, October 7, 2015, 7:40:45 PM, you wrote: >> >> w> There's no automagic way to get this done. >> >> w> Hardware accelerators like vaapi and vdpau need the same

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-14 Thread Hendrik Leppkes
On Wed, Oct 7, 2015 at 7:07 PM, Ivan Uskov wrote: > Hello wm4, > > Wednesday, October 7, 2015, 7:40:45 PM, you wrote: > > w> There's no automagic way to get this done. > > w> Hardware accelerators like vaapi and vdpau need the same thing. These > w> have special APIs to set an API context on the d

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-07 Thread Ivan Uskov
Hello wm4, Wednesday, October 7, 2015, 7:40:45 PM, you wrote: w> There's no automagic way to get this done. w> Hardware accelerators like vaapi and vdpau need the same thing. These w> have special APIs to set an API context on the decoder. Some APIs use w> hwaccel_context, vdpau uses av_vdpau_bi

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-07 Thread wm4
On Wed, 7 Oct 2015 19:20:56 +0300 Ivan Uskov wrote: > Hello Hendrik, > > Wednesday, October 7, 2015, 5:58:25 PM, you wrote: > > HL> On Wed, Oct 7, 2015 at 4:41 PM, Ivan Uskov wrote: > > HL> Global static variables are not acceptable, sorry. > HL> You'll have to find another way to solve your

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-07 Thread Ivan Uskov
Hello Hendrik, Wednesday, October 7, 2015, 5:58:25 PM, you wrote: HL> On Wed, Oct 7, 2015 at 4:41 PM, Ivan Uskov wrote: HL> Global static variables are not acceptable, sorry. HL> You'll have to find another way to solve your problem, but global HL> state is not the way to go. Unfortunately I

Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-07 Thread Hendrik Leppkes
On Wed, Oct 7, 2015 at 4:41 PM, Ivan Uskov wrote: > Hello All, > > The attached patch represents new design for qsv session control and internal > allocation. All qsv modules now uses instance of AVQSVContext so now session > allocates by external application and session allocates internally by f

[FFmpeg-devel] [PATCH] libavcodec/qsv.c: Re-design session control and internal allocation

2015-10-07 Thread Ivan Uskov
Hello All, The attached patch represents new design for qsv session control and internal allocation. All qsv modules now uses instance of AVQSVContext so now session allocates by external application and session allocates internally by ffmpeg itself handles by unified way. For the case of int