Re: [FFmpeg-devel] [PATCH] libavcodec/zmbvenc: Add support for RGB formats

2019-03-14 Thread Tomas Härdin
tor 2019-03-14 klockan 11:12 +0100 skrev Tomas Härdin: > ons 2019-03-13 klockan 17:46 + skrev Matthew Fearnley: > > > > > > > By the way, I’m happy for this patch to be committed as-is (possibly > > without the extra note on unsupported bit depths, if that causes any > > issues). Any new

Re: [FFmpeg-devel] [PATCH] libavcodec/zmbvenc: Add support for RGB formats

2019-03-14 Thread Tomas Härdin
ons 2019-03-13 klockan 17:46 + skrev Matthew Fearnley: > > > > On 12 Mar 2019, at 11:46, Tomas Härdin wrote: > > > > tis 2019-03-12 klockan 10:27 + skrev Matthew Fearnley: > > > > > > > It occurs to me that adding sub-8bpp has some implications: > > > > > > My current understanding (I

Re: [FFmpeg-devel] [PATCH] libavcodec/zmbvenc: Add support for RGB formats

2019-03-13 Thread Matthew Fearnley
> On 12 Mar 2019, at 11:46, Tomas Härdin wrote: > > tis 2019-03-12 klockan 10:27 + skrev Matthew Fearnley: >>> On 11 Mar 2019, at 10:37, Tomas Härdin wrote: >>> >>> >>> There's some justification for adding sub-8bpp, like BMP. bmp.c >>> converts all of them except GRAY8 to PAL8.

Re: [FFmpeg-devel] [PATCH] libavcodec/zmbvenc: Add support for RGB formats

2019-03-12 Thread Tomas Härdin
tis 2019-03-12 klockan 10:27 + skrev Matthew Fearnley: > > On 11 Mar 2019, at 10:37, Tomas Härdin wrote: > > > > > > There's some justification for adding sub-8bpp, like BMP. bmp.c > > converts all of them except GRAY8 to PAL8. Bitdepths besides 1, 4 > > and 8 > > don't work at all. > > >

Re: [FFmpeg-devel] [PATCH] libavcodec/zmbvenc: Add support for RGB formats

2019-03-12 Thread Matthew Fearnley
> On 11 Mar 2019, at 10:37, Tomas Härdin wrote: > > fre 2019-03-08 klockan 21:39 + skrev Matthew Fearnley: On Fri, 8 Mar 2019 at 18:07, Carl Eugen Hoyos wrote: 2019-03-08 15:04 GMT+01:00, Tomas Härdin : Maybe we could coordinate 1/2/4/24-bit support with the >>> >>> I

Re: [FFmpeg-devel] [PATCH] libavcodec/zmbvenc: Add support for RGB formats

2019-03-11 Thread Carl Eugen Hoyos
2019-03-11 12:07 GMT+01:00, Tomas Härdin : > mån 2019-03-11 klockan 11:43 +0100 skrev Carl Eugen Hoyos: >> > 2019-03-11 11:37 GMT+01:00, Tomas Härdin : >> > fre 2019-03-08 klockan 21:39 + skrev Matthew Fearnley: >> > > > On Fri, 8 Mar 2019 at 18:07, Carl Eugen Hoyos >> > > > wrote: >> > > > >

Re: [FFmpeg-devel] [PATCH] libavcodec/zmbvenc: Add support for RGB formats

2019-03-11 Thread Tomas Härdin
mån 2019-03-11 klockan 11:43 +0100 skrev Carl Eugen Hoyos: > > 2019-03-11 11:37 GMT+01:00, Tomas Härdin : > > fre 2019-03-08 klockan 21:39 + skrev Matthew Fearnley: > > > > On Fri, 8 Mar 2019 at 18:07, Carl Eugen Hoyos > > > > wrote: > > > > > > > > 2019-03-08 15:04 GMT+01:00, Tomas Härdin :

Re: [FFmpeg-devel] [PATCH] libavcodec/zmbvenc: Add support for RGB formats

2019-03-11 Thread Carl Eugen Hoyos
2019-03-11 11:37 GMT+01:00, Tomas Härdin : > fre 2019-03-08 klockan 21:39 + skrev Matthew Fearnley: >> > On Fri, 8 Mar 2019 at 18:07, Carl Eugen Hoyos >> > wrote: >> > 2019-03-08 15:04 GMT+01:00, Tomas Härdin : >> > > >> > > Maybe we could coordinate 1/2/4/24-bit support with the >> > >> > I

Re: [FFmpeg-devel] [PATCH] libavcodec/zmbvenc: Add support for RGB formats

2019-03-11 Thread Tomas Härdin
fre 2019-03-08 klockan 21:39 + skrev Matthew Fearnley: > > On Fri, 8 Mar 2019 at 18:07, Carl Eugen Hoyos wrote: > > 2019-03-08 15:04 GMT+01:00, Tomas Härdin : > > > > > > Maybe we could coordinate 1/2/4/24-bit support with the > > > > I believe FFmpeg cannot support 1/2/4 bit for encoding.

Re: [FFmpeg-devel] [PATCH] libavcodec/zmbvenc: Add support for RGB formats

2019-03-08 Thread Matthew Fearnley
On Fri, 8 Mar 2019 at 18:07, Carl Eugen Hoyos wrote: > 2019-03-08 15:04 GMT+01:00, Tomas Härdin : > > tor 2019-03-07 klockan 14:42 + skrev Matthew Fearnley: > >> This consists mostly of the following changes: > >> - add newly supported pixel formats (RGB555LE, RGB565LE, BGR0) > >> - select

Re: [FFmpeg-devel] [PATCH] libavcodec/zmbvenc: Add support for RGB formats

2019-03-08 Thread Carl Eugen Hoyos
2019-03-08 15:04 GMT+01:00, Tomas Härdin : > tor 2019-03-07 klockan 14:42 + skrev Matthew Fearnley: >> This consists mostly of the following changes: >> - add newly supported pixel formats (RGB555LE, RGB565LE, BGR0) >> - select the ZMBV format (c->fmt) and bytes per pixel (c->bypp) based on >>

Re: [FFmpeg-devel] [PATCH] libavcodec/zmbvenc: Add support for RGB formats

2019-03-08 Thread Tomas Härdin
tor 2019-03-07 klockan 14:42 + skrev Matthew Fearnley: > This consists mostly of the following changes: > - add newly supported pixel formats (RGB555LE, RGB565LE, BGR0) > - select the ZMBV format (c->fmt) and bytes per pixel (c->bypp) based on >   avctx->pix_fmt > - multiply widths/x-values by

[FFmpeg-devel] [PATCH] libavcodec/zmbvenc: Add support for RGB formats

2019-03-07 Thread Matthew Fearnley
This consists mostly of the following changes: - add newly supported pixel formats (RGB555LE, RGB565LE, BGR0) - select the ZMBV format (c->fmt) and bytes per pixel (c->bypp) based on avctx->pix_fmt - multiply widths/x-values by c->bypp, in places where bytes, not pixels, are expected - disable