Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-29 Thread Li, Zhong
> > But the CODE doesn't say that! > > > > The code uses: > > "#if QSV_HAVE_CO3" > > > > And then every use of the "co3" member needs to be protected by this > clausule. > > Futhermore, this is true in every part of the source code in > > "qsvenc.c"... except at two points (I need to review my

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-23 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Tuesday, 23 de April de 2019 9:29, Andreas Håkon wrote: > ‐‐‐ Original Message ‐‐‐ > On Tuesday, 23 de April de 2019 8:39, Li, Zhong zhong...@intel.com wrote: > > > I belive they are different. If you extend the MARCIO, they are actually: > > IMHO,

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-23 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Tuesday, 23 de April de 2019 8:39, Li, Zhong wrote: > > I belive they are different. If you extend the MARCIO, they are actually: > > > IMHO, your patch is only needed when disable "QSV_HAVE_CO3", but tiket#7839 > is not root caused now. > I will consider to

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-23 Thread Li, Zhong
; Sent: Thursday, April 18, 2019 6:11 PM > > > To: FFmpeg development discussions and patches > > > ffmpeg-devel@ffmpeg.org > > > Cc: Andreas Håkon andreas.ha...@protonmail.com > > > Subject: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code > > > w

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-22 Thread myp...@gmail.com
> Cc: Andreas Håkon andreas.ha...@protonmail.com > > > > Subject: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with > > > > CO3 define > > > > Hi, > > > > In response to this ticket I provide the first part of the patch: > >

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-22 Thread Andreas Håkon
ffmpeg-devel > > > Sent: Thursday, April 18, 2019 6:11 PM > > > To: FFmpeg development discussions and patches > > > ffmpeg-devel@ffmpeg.org > > > Cc: Andreas Håkon andreas.ha...@protonmail.com > > > Subject: [FFmpeg-devel] [PATCH] libavcodec: Q

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-22 Thread myp...@gmail.com
gt; > Cc: Andreas Håkon > > Subject: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with > > CO3 define > > > > Hi, > > > > In response to this ticket I provide the first part of the patch: > > https://trac.ffmpeg.org/ticket/7839 > > >

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-22 Thread Andreas Håkon
discussions and patches > > ffmpeg-devel@ffmpeg.org > > Cc: Andreas Håkon andreas.ha...@protonmail.com > > Subject: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with > > CO3 define > > Hi, > > In response to this ticket I provide the firs

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-22 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Andreas Håkon via ffmpeg-devel > Sent: Thursday, April 18, 2019 6:11 PM > To: FFmpeg development discussions and patches > > Cc: Andreas Håkon > Subject: [FFmpeg-devel] [PATCH] libavcodec:

[FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-18 Thread Andreas Håkon via ffmpeg-devel
Hi, In response to this ticket I provide the first part of the patch: https://trac.ffmpeg.org/ticket/7839 This QSV_HAVE_GPB code needs to be protected by QSV_HAVE_CO3. Regards. A.H. ---From d43c81f5bba49e55ea867bd6afd2eef878dc0ad3 Mon Sep 17 00:00:00 2001 From: Andreas Hakon Date: Thu, 18 Apr