Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: extend available actions on signal loss

2024-03-05 Thread Michael Riedl
Ping.  Anything missing or wrong with this patch? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: extend available actions on signal loss

2024-01-09 Thread Michael Riedl
On 11/28/23 16:48, Devin Heitmueller wrote: > My apologies, I saw your remarks that this didn't change backward > compatibility but failed to reply. I have no further issues with this > patch. > > Thanks, > > Devin Ping. Can this please be merged? Thanks.

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: extend available actions on signal loss

2023-11-28 Thread Devin Heitmueller
On Tue, Nov 28, 2023 at 4:22 AM Michael Riedl wrote: > > Ping My apologies, I saw your remarks that this didn't change backward compatibility but failed to reply. I have no further issues with this patch. Thanks, Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: extend available actions on signal loss

2023-11-28 Thread Michael Riedl
Ping ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: extend available actions on signal loss

2023-11-02 Thread Michael Riedl
> Hi Michael, > > I haven't tried your patch, but a quick review suggests that while > you've declared the option as deprecated that it no longer works. > Presumably somewhere in there should be a line of code that says > something like "if (ctx->draw_bars == 0) then ctx->signal_loss_action > =

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: extend available actions on signal loss

2023-11-02 Thread Devin Heitmueller
Hi Michael, I haven't tried your patch, but a quick review suggests that while you've declared the option as deprecated that it no longer works. Presumably somewhere in there should be a line of code that says something like "if (ctx->draw_bars == 0) then ctx->signal_loss_action =

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: extend available actions on signal loss

2023-11-02 Thread Michael Riedl
On 9/25/23 13:58, Michael Riedl wrote: > Deprecate the option 'draw_bars' in favor of the new option > 'signal_loss_action', > which controls the behavior when the input signal is not available > (including the behavior previously available through draw_bars). > The default behavior remains

[FFmpeg-devel] [PATCH] libavdevice/decklink: extend available actions on signal loss

2023-09-25 Thread Michael Riedl
Deprecate the option 'draw_bars' in favor of the new option 'signal_loss_action', which controls the behavior when the input signal is not available (including the behavior previously available through draw_bars). The default behavior remains unchanged to be backwards compatible. The new option