Hi Paul, Marton and Andriy,
I have updated the patch following the comments.
The first part that solves only the PCR bug with multiple programs
is already published:
https://patchwork.ffmpeg.org/patch/14036/
I hope it will soon be accepted.
Regards.
A.H.
---
Hi Paul,
> > I disagree. Based on your code the 4 modes do this:
> > < -1 = 0
> > -1 = WRITE_HEADER
> > 0 = WRITE_HEADER | ONE_PACKET_ONLY
> >
> > > 0 = ONE_PACKET_ONLY
> >
> > You documented the meaning of the "modes" in two places and created two
> > helper functions to make sure you pass the
Hi Marton,
> > > > > > - ts_st->payload = av_mallocz(ts->pes_payload_size);
> > > > > > + ts_st->payload = av_mallocz(ts->parallel_mux ?
> > > > > > MAX_PES_PAYLOAD : ts->pes_payload_size);
> > > > > >
> > > > >
> > > > > Could you clarify why this needs to be changed?
On 6/30/19, Marton Balint wrote:
>
>
> On Wed, 26 Jun 2019, Andreas Håkon wrote:
>
>>> > > > -ts_st->payload = av_mallocz(ts->pes_payload_size);
>>> > > > +ts_st->payload = av_mallocz(ts->parallel_mux ?
>>> > > > MAX_PES_PAYLOAD : ts->pes_payload_size);
>>> > >
>>> > >
On Wed, 26 Jun 2019, Andreas Håkon wrote:
> > > -ts_st->payload = av_mallocz(ts->pes_payload_size);
> > > +ts_st->payload = av_mallocz(ts->parallel_mux ? MAX_PES_PAYLOAD
: ts->pes_payload_size);
> >
> > Could you clarify why this needs to be changed?
>
> Sure! Because
Hi,
> Thank you for reviewing!
New version [v2] at: https://patchwork.ffmpeg.org/patch/13745/
Regards.
A.H.
---
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link
Hi Marton,
> Ok. But I believe the correct term for this is "interleaved". I have
> never heard "interlaced" used for TS packets.
I feel you're right: the name "interleaved mux mode" is preferable.
Thank you for pointing it out!
> > > > +#define PES_START 1 /* 0001 /
> > > > +#define
On Thu, 13 Jun 2019, Andreas Håkon wrote:
Hi Andriy,
I'm glad you're interested in this patch.
> This patch implements a new optional "parallel muxing mode" in the MPEGTS
muxer.
> The strategy that implements the current mux (selected by default) is based on
> writing full PES packages
Hi Andriy,
I'm glad you're interested in this patch.
> > This patch implements a new optional "parallel muxing mode" in the MPEGTS
> > muxer.
> > The strategy that implements the current mux (selected by default) is based
> > on
> > writing full PES packages sequentially. This mode can be
Hello,
On Mon, 10. Jun 17:29, Andreas Håkon wrote:
> Hi,
>
> Here is a list of comments on this patch:
> (Note: I use for all the tests the file
> https://samples.ffmpeg.org/HDTV/bshi01.tp)
>
> - By default the current behavior is selected. You can verify that this
> patch doesn’t alter the
Hi,
An additional comment on the matter...
‐‐‐ Original Message ‐‐‐
On Monday, 10 de June de 2019 19:29, Andreas Håkon
wrote:
> Hi,
>
> ---
>
> ---
> From aa02575cc11bed0fd2ae2a01368c8673ad48e64b Mon Sep 17 00:00:00 2001
>
> From: Andreas Hakon <
> andreas.ha...@protonmail.com
>>
>
>
Hi,
Here is a list of comments on this patch:
(Note: I use for all the tests the file
https://samples.ffmpeg.org/HDTV/bshi01.tp)
- By default the current behavior is selected. You can verify that this
patch doesn’t alter the original behavior with this simple test:
$ ffmpeg-original -i
12 matches
Mail list logo
