Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-24 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Wednesday, 24 de April de 2019 0:58, Michael Niedermayer wrote: > On Tue, Apr 23, 2019 at 11:55:59PM +0200, Michael Niedermayer wrote: > > > On Tue, Apr 23, 2019 at 07:16:07AM +, Andreas Håkon wrote: > > > > > ‐‐‐ Original Message ‐‐‐ > > > > > >

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-23 Thread Michael Niedermayer
On Tue, Apr 23, 2019 at 11:55:59PM +0200, Michael Niedermayer wrote: > On Tue, Apr 23, 2019 at 07:16:07AM +, Andreas Håkon wrote: > > > > ‐‐‐ Original Message ‐‐‐ > > On Tuesday, 23 de April de 2019 1:07, Michael Niedermayer > > wrote: > > > > > On Mon, Apr 22, 2019 at 11:42:57AM

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-23 Thread Michael Niedermayer
On Tue, Apr 23, 2019 at 07:16:07AM +, Andreas Håkon wrote: > > ‐‐‐ Original Message ‐‐‐ > On Tuesday, 23 de April de 2019 1:07, Michael Niedermayer > wrote: > > > On Mon, Apr 22, 2019 at 11:42:57AM +, Andreas Håkon wrote: > > > > > > > Please, revise the code! I hope you

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-23 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Tuesday, 23 de April de 2019 1:07, Michael Niedermayer wrote: > On Mon, Apr 22, 2019 at 11:42:57AM +, Andreas Håkon wrote: > > > > Please, revise the code! I hope you understand it when you look at my > > descriptions. > > I would prefer to have some

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-22 Thread Michael Niedermayer
On Mon, Apr 22, 2019 at 11:42:57AM +, Andreas Håkon wrote: > > ‐‐‐ Original Message ‐‐‐ > On Friday, 19 de April de 2019 17:08, Michael Niedermayer > wrote: > > > On Fri, Apr 19, 2019 at 08:23:35AM +, Andreas Håkon via ffmpeg-devel > > wrote: > > > > > From

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-22 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Friday, 19 de April de 2019 17:08, Michael Niedermayer wrote: > On Fri, Apr 19, 2019 at 08:23:35AM +, Andreas Håkon via ffmpeg-devel > wrote: > > > From 936740731c17a9757aa093bdb35d9772df1e64a8 Mon Sep 17 00:00:00 2001 > > From: Andreas Hakon

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-19 Thread Michael Niedermayer
On Fri, Apr 19, 2019 at 08:23:35AM +, Andreas Håkon via ffmpeg-devel wrote: > > ‐‐‐ Original Message ‐‐‐ > On Thursday, 18 de April de 2019 22:07, Michael Niedermayer > wrote: > > > > > fails to apply cleanly > > > > Applying: libavformat: fix inputs initialization in mpegts muxer

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-19 Thread Andreas Håkon via ffmpeg-devel
‐‐‐ Original Message ‐‐‐ On Thursday, 18 de April de 2019 22:07, Michael Niedermayer wrote: > > fails to apply cleanly > > Applying: libavformat: fix inputs initialization in mpegts muxer with filters > Using index info to reconstruct a base tree... > error: patch failed:

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-18 Thread Michael Niedermayer
On Thu, Apr 18, 2019 at 11:18:13AM +, Andreas Håkon via ffmpeg-devel wrote: > > > ‐‐‐ Original Message ‐‐‐ > On Thursday, 18 de April de 2019 13:14, Andreas Håkon > wrote: > > > > On Wed, Apr 17, 2019 at 08:28:39PM +, Andreas Håkon via ffmpeg-devel > > > wrote: > > > > > > >

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-18 Thread Michael Niedermayer
On Thu, Apr 18, 2019 at 11:14:39AM +, Andreas Håkon via ffmpeg-devel wrote: > > > On Wed, Apr 17, 2019 at 08:28:39PM +, Andreas Håkon via ffmpeg-devel > > wrote: > > > > > This patch solves the initialization of the inputs when using filters (a > > > graph filter) with the mpegts muxer.

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-18 Thread Andreas Håkon via ffmpeg-devel
‐‐‐ Original Message ‐‐‐ On Thursday, 18 de April de 2019 13:14, Andreas Håkon wrote: > > On Wed, Apr 17, 2019 at 08:28:39PM +, Andreas Håkon via ffmpeg-devel > > wrote: > > > > > This patch solves the initialization of the inputs when using filters (a > > > graph filter) with

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-18 Thread Andreas Håkon via ffmpeg-devel
> On Wed, Apr 17, 2019 at 08:28:39PM +, Andreas Håkon via ffmpeg-devel > wrote: > > > This patch solves the initialization of the inputs when using filters (a > > graph filter) with the mpegts muxer. > > This bug seems to be generated by a simple forgetting to copy. The same > > code is

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-18 Thread Michael Niedermayer
On Wed, Apr 17, 2019 at 08:28:39PM +, Andreas Håkon via ffmpeg-devel wrote: > This patch solves the initialization of the inputs when using filters (a > graph filter) with the mpegts muxer. > > This bug seems to be generated by a simple forgetting to copy. The same code > is repeated two

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-18 Thread Andreas Håkon via ffmpeg-devel
> Hi Carl, > > > Please split the patch. > > Carl Eugen > > OK. Here the relevant part regargind the bug fix. > I'll send another new with the log enhancement. > > Regards. > A.H. > This supersedes my previous PATCH: https://patchwork.ffmpeg.org/patch/12783/ So, please, mark it as superseded.

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-18 Thread Andreas Håkon via ffmpeg-devel
Hi Carl, > > Please split the patch. > > Carl Eugen > OK. Here the relevant part regargind the bug fix. I'll send another new with the log enhancement. Regards. A.H. From af81338c21c67c0ef2c30ab2009c7094b32327f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andreas=20H=C3=A5kon?= Date: Wed, 17

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-17 Thread Carl Eugen Hoyos
2019-04-17 22:28 GMT+02:00, Andreas Håkon via ffmpeg-devel : > This patch solves the initialization of the inputs when using filters (a > graph filter) with the mpegts muxer. > > This bug seems to be generated by a simple forgetting to copy. The same code > is repeated two times, but only in one

[FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-17 Thread Andreas Håkon via ffmpeg-devel
This patch solves the initialization of the inputs when using filters (a graph filter) with the mpegts muxer. This bug seems to be generated by a simple forgetting to copy. The same code is repeated two times, but only in one case the variable “inputs_done” is initialized. Compare the two