Re: [FFmpeg-devel] [PATCH] libavutil/log: Support for logging timestamps in the log

2023-02-17 Thread Prakash
Logging timestamps is a basic functionality any logging framework/infrastructure should support. If I am using ffmpeg as a binary then I would need this functionality built in. Agree that the code in log.c can definitely be simplified but didn't want to make any changes with potential for breaking

Re: [FFmpeg-devel] [PATCH] libavutil/log: Support for logging timestamps in the log

2023-02-17 Thread Lynne
Feb 17, 2023, 12:08 by an...@khirnov.net: > Quoting Prakash (2023-02-17 01:16:04) > >> Moved the timestamp to the front (before loglevel but after the prefix if >> present, so the timestamp has the same color as log line based on log >> level). Updated the patch and attached again. >> >> >> From

Re: [FFmpeg-devel] [PATCH] libavutil/log: Support for logging timestamps in the log

2023-02-17 Thread Anton Khirnov
Quoting Prakash (2023-02-17 01:16:04) > Moved the timestamp to the front (before loglevel but after the prefix if > present, so the timestamp has the same color as log line based on log > level). Updated the patch and attached again. > > > From 04857a7bf0d4cf24a479e795a55a61ab2e2f618e Mon Sep

Re: [FFmpeg-devel] [PATCH] libavutil/log: Support for logging timestamps in the log

2023-02-16 Thread Prakash
Moved the timestamp to the front (before loglevel but after the prefix if present, so the timestamp has the same color as log line based on log level). Updated the patch and attached again. >From 04857a7bf0d4cf24a479e795a55a61ab2e2f618e Mon Sep 17 00:00:00 2001 From: Prakash Duggaraju Date:

Re: [FFmpeg-devel] [PATCH] libavutil/log: Support for logging timestamps in the log

2023-01-19 Thread Tobias Rapp
On 19/01/2023 00:20, Prakash wrote: The problem with int milliseconds is you lose the microseconds precision. Sometimes there are multiple log lines within the same millisecond. If you want to do performance profiling like comparing between assembler and C versions of a routine in my opinion

Re: [FFmpeg-devel] [PATCH] libavutil/log: Support for logging timestamps in the log

2023-01-18 Thread Prakash
The problem with int milliseconds is you lose the microseconds precision. Sometimes there are multiple log lines within the same millisecond. I can definitely move the timestamp as the first field of the log line. Let me fix the patch file. -Prakash. On Wed, Jan 18, 2023 at 12:51 AM Tobias Rapp

Re: [FFmpeg-devel] [PATCH] libavutil/log: Support for logging timestamps in the log

2023-01-18 Thread Tobias Rapp
On 17/01/2023 22:52, Prakash wrote: libavutil/log: Support for logging timestamps in the log. Add 'time' flag to the -loglevel option to turn on timestamp logging. Useful for troubleshooting where time is spent from the log files. Signed-off-by: Prakash Duggaraju The commit message seems to

[FFmpeg-devel] [PATCH] libavutil/log: Support for logging timestamps in the log

2023-01-17 Thread Prakash
libavutil/log: Support for logging timestamps in the log. Add 'time' flag to the -loglevel option to turn on timestamp logging. Useful for troubleshooting where time is spent from the log files. Signed-off-by: Prakash Duggaraju --- doc/fftools-common-opts.texi | 4 fftools/opt_common.c