[FFmpeg-devel] [PATCH] libsvtav1: Add logical_processors option

2021-03-10 Thread Christopher Degawa
From: Christopher Degawa Used for limiting the size of memory buffers and threads for a target logical processor count, but does not set thread affinity or the total amount of threads used, although thread affinities can be controlled with an additional parameters, it is prefered to add them unti

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add logical_processors option

2021-02-17 Thread Christopher Degawa
> > It does seem like the number correlates somehow with how much CPU it > uses, but it's not an upper bound. > If it isn't, then that might be an issue, but the idea is that with the logical_processor option you can limit the amount of ram a single encoder instance will use since on a system wit

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add logical_processors option

2021-02-17 Thread Mark Thompson
On 17/02/2021 18:58, Christopher Degawa wrote: On Sun, Feb 14, 2021 at 12:27 PM Christopher Degawa wrote: That said, if you have a general use-case where this is helpful and the documentation explains what it is doing (and warns about the bad cases) then maybe? The main use case we have in

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add logical_processors option

2021-02-17 Thread Christopher Degawa
On Sun, Feb 14, 2021 at 12:27 PM Christopher Degawa wrote: > That said, if you have a general use-case where this is helpful and the >> documentation explains what it is doing (and warns about the bad cases) >> then maybe? >> > > The main use case we have internally is to able to run multiple ins

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add logical_processors option

2021-02-14 Thread Christopher Degawa
> > That said, if you have a general use-case where this is helpful and the > documentation explains what it is doing (and warns about the bad cases) > then maybe? > The main use case we have internally is to able to run multiple instances of SvtAv1EncApp with `--lp 1` without worrying about poten

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add logical_processors option

2021-02-11 Thread Paul B Mahol
On Thu, Feb 11, 2021 at 11:15 PM Mark Thompson wrote: > On 10/02/2021 23:53, Paul B Mahol wrote: > > On Wed, Feb 10, 2021 at 11:08 PM Mark Thompson wrote: > > > >> On 10/02/2021 17:16, Christopher Degawa wrote: > >>> From: Christopher Degawa > >>> > >>> Equivalent to the --lp option for SvtAv1E

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add logical_processors option

2021-02-11 Thread Mark Thompson
On 10/02/2021 23:49, Christopher Degawa wrote: Based on my limited understanding of the code, it's limiting the usage using pthread_setaffinity_np and CPU_SET on Linux to limit the process to certain CPUs, but it also has a default and max of the return of `sysconf(_SC_NPROCESSORS_ONLN)`. Accordi

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add logical_processors option

2021-02-11 Thread Mark Thompson
On 10/02/2021 23:53, Paul B Mahol wrote: On Wed, Feb 10, 2021 at 11:08 PM Mark Thompson wrote: On 10/02/2021 17:16, Christopher Degawa wrote: From: Christopher Degawa Equivalent to the --lp option for SvtAv1EncApp, and is the only way to control how much cpu power svt-av1 uses for now Not

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add logical_processors option

2021-02-10 Thread Paul B Mahol
On Wed, Feb 10, 2021 at 11:08 PM Mark Thompson wrote: > On 10/02/2021 17:16, Christopher Degawa wrote: > > From: Christopher Degawa > > > > Equivalent to the --lp option for SvtAv1EncApp, and is the only way > > to control how much cpu power svt-av1 uses for now > > > > Not using thread_count as

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add logical_processors option

2021-02-10 Thread Christopher Degawa
Based on my limited understanding of the code, it's limiting the usage using pthread_setaffinity_np and CPU_SET on Linux to limit the process to certain CPUs, but it also has a default and max of the return of `sysconf(_SC_NPROCESSORS_ONLN)`. According to Hassene Tmar of SVT-AV1, it is a "target co

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add logical_processors option

2021-02-10 Thread Mark Thompson
On 10/02/2021 17:16, Christopher Degawa wrote: From: Christopher Degawa Equivalent to the --lp option for SvtAv1EncApp, and is the only way to control how much cpu power svt-av1 uses for now Not using thread_count as it would be preferable to reserve that until svt-av1 properly implements a th

[FFmpeg-devel] [PATCH] libsvtav1: Add logical_processors option

2021-02-10 Thread Christopher Degawa
From: Christopher Degawa Equivalent to the --lp option for SvtAv1EncApp, and is the only way to control how much cpu power svt-av1 uses for now Not using thread_count as it would be preferable to reserve that until svt-av1 properly implements a threads option 0 == getconf _NPROCESSORS_ONLN Sig