Of course, I will update the patch and send it out shortly.
Using in.ch_count should be ok. The relevant check is in swresample.c:292,
so we should never reach that code if the in.ch_count is 0.
On Fri, Jul 20, 2018 at 7:36 PM Michael Niedermayer
wrote:
> On Fri, Jul 20, 2018 at 09:51:49AM
On Fri, Jul 20, 2018 at 09:51:49AM +0200, Tobias Rapp wrote:
> On 19.07.2018 23:37, Michael Niedermayer wrote:
> >On Thu, Jul 19, 2018 at 01:53:09PM +0200, Tobias Rapp wrote:
> >>On 18.07.2018 19:31, Marcin Gorzel wrote:
> >>>Rematrixing supports up to 64 channels. However, there is only a limited
On 19.07.2018 23:37, Michael Niedermayer wrote:
On Thu, Jul 19, 2018 at 01:53:09PM +0200, Tobias Rapp wrote:
On 18.07.2018 19:31, Marcin Gorzel wrote:
Rematrixing supports up to 64 channels. However, there is only a limited number
of channel layouts defined. Since the in/out channel count is
On Thu, Jul 19, 2018 at 01:53:09PM +0200, Tobias Rapp wrote:
> On 18.07.2018 19:31, Marcin Gorzel wrote:
> >Rematrixing supports up to 64 channels. However, there is only a limited
> >number of channel layouts defined. Since the in/out channel count is
> >obtained from the channel layout, for
Hi Tobias,
Sounds good, thanks a lot!
Regards,
Marcin
On Thu, Jul 19, 2018 at 12:53 PM Tobias Rapp wrote:
> On 18.07.2018 19:31, Marcin Gorzel wrote:
> > Rematrixing supports up to 64 channels. However, there is only a limited
> number of channel layouts defined. Since the in/out channel
On 18.07.2018 19:31, Marcin Gorzel wrote:
Rematrixing supports up to 64 channels. However, there is only a limited number
of channel layouts defined. Since the in/out channel count is obtained from the
channel layout, for undefined layouts (e.g. for 9, 10, 11 channels etc.) the
rematrixing
Rematrixing supports up to 64 channels. However, there is only a limited number
of channel layouts defined. Since the in/out channel count is obtained from the
channel layout, for undefined layouts (e.g. for 9, 10, 11 channels etc.) the
rematrixing fails.
In ticket #6790 the problem has been
Thanks for your input Tobias!
On Wed, Jul 18, 2018 at 3:23 PM Tobias Rapp wrote:
> On 13.07.2018 13:43, Marcin Gorzel wrote:
> > Rematrixing supports up to 64 channels. However, there is only a limited
> number of channel layouts defined. Since the in/out channel count is
> obtained from the
On 13.07.2018 13:43, Marcin Gorzel wrote:
Rematrixing supports up to 64 channels. However, there is only a limited number
of channel layouts defined. Since the in/out channel count is obtained from the
channel layout, for undefined layouts (e.g. for 9, 10, 11 channels etc.) the
rematrixing
Hi Michael,
Of course we should not check in a change that is incorrect. So thank you
for your thorough review.
However, could you help me understand which part exactly of the below do
you think is incorrect?
Before:
int nb_in = av_get_channel_layout_nb_channels(s->in_ch_layout);
This is
On Mon, Jul 16, 2018 at 03:37:15PM +0100, Marcin Gorzel wrote:
> Hi Michael,
>
> On Sat, Jul 14, 2018 at 4:01 PM Michael Niedermayer
> wrote:
>
> > On Fri, Jul 13, 2018 at 12:43:36PM +0100, Marcin Gorzel wrote:
> > > Rematrixing supports up to 64 channels. However, there is only a limited
> >
Hi Michael,
On Sat, Jul 14, 2018 at 4:01 PM Michael Niedermayer
wrote:
> On Fri, Jul 13, 2018 at 12:43:36PM +0100, Marcin Gorzel wrote:
> > Rematrixing supports up to 64 channels. However, there is only a limited
> number of channel layouts defined. Since the in/out channel count is
> obtained
On Fri, Jul 13, 2018 at 12:43:36PM +0100, Marcin Gorzel wrote:
> Rematrixing supports up to 64 channels. However, there is only a limited
> number of channel layouts defined. Since the in/out channel count is obtained
> from the channel layout, for undefined layouts (e.g. for 9, 10, 11 channels
Rematrixing supports up to 64 channels. However, there is only a limited number
of channel layouts defined. Since the in/out channel count is obtained from the
channel layout, for undefined layouts (e.g. for 9, 10, 11 channels etc.) the
rematrixing fails.
In ticket #6790 the problem has been
14 matches
Mail list logo
