Re: [FFmpeg-devel] [PATCH] movenc: Always write the trun data_offset

2014-10-29 Thread Michael Niedermayer
On Wed, Oct 29, 2014 at 08:49:11PM -0700, Bryan Huh wrote: > Yes. Even with his change to the if-statement, I am proposing the same > change: to remove the if-statement. > > It would be nice to get this sanity-checked by Martin though. ok, cc-ing martin > > On Wed, Oct 29, 2014 at 7:24 PM, Mic

Re: [FFmpeg-devel] [PATCH] movenc: Always write the trun data_offset

2014-10-29 Thread Bryan Huh
Yes. Even with his change to the if-statement, I am proposing the same change: to remove the if-statement. It would be nice to get this sanity-checked by Martin though. On Wed, Oct 29, 2014 at 7:24 PM, Michael Niedermayer wrote: > On Tue, Oct 28, 2014 at 11:05:54PM +, Bryan Huh wrote: > > T

Re: [FFmpeg-devel] [PATCH] movenc: Always write the trun data_offset

2014-10-29 Thread Michael Niedermayer
On Tue, Oct 28, 2014 at 11:05:54PM +, Bryan Huh wrote: > The MOV_TRUN_DATA_OFFSET flag was always getting set, so data_offset is > being expected and read. The offset was computed correctly anyway during > fragment-flush. Alternatively, I could have selectively set the flag > only when base-dat

[FFmpeg-devel] [PATCH] movenc: Always write the trun data_offset

2014-10-28 Thread Bryan Huh
The MOV_TRUN_DATA_OFFSET flag was always getting set, so data_offset is being expected and read. The offset was computed correctly anyway during fragment-flush. Alternatively, I could have selectively set the flag only when base-data-offset is defined, but certain players (Chrome) seem to fail when