Re: [FFmpeg-devel] [PATCH] opus_pvq_search: Restore the proper use of conditional define and simplify the function name suffix handling

2017-08-19 Thread Ivan Kalvachev
The issue has been resolved. The patch has been pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] opus_pvq_search: Restore the proper use of conditional define and simplify the function name suffix handling

2017-08-19 Thread Hendrik Leppkes
On Sat, Aug 19, 2017 at 5:40 PM, Rostislav Pehlivanov wrote: > On 19 August 2017 at 16:10, Ivan Kalvachev wrote: > >> Using named define properly documents the code paths. >> It also avoids passing additional numbered arguments through >> multiple

Re: [FFmpeg-devel] [PATCH] opus_pvq_search: Restore the proper use of conditional define and simplify the function name suffix handling

2017-08-19 Thread Rostislav Pehlivanov
On 19 August 2017 at 16:10, Ivan Kalvachev wrote: > Using named define properly documents the code paths. > It also avoids passing additional numbered arguments through > multiple levels of macro templates. > > The suffix handling is done by concatenation, like in > other

[FFmpeg-devel] [PATCH] opus_pvq_search: Restore the proper use of conditional define and simplify the function name suffix handling

2017-08-19 Thread Ivan Kalvachev
Using named define properly documents the code paths. It also avoids passing additional numbered arguments through multiple levels of macro templates. The suffix handling is done by concatenation, like in other asm functions and avoid having two separate "cglobal" defines. --- I have to point