Re: [FFmpeg-devel] [PATCH] qsvenc: write a53 caption data to SEI

2015-11-30 Thread Michael Niedermayer
On Mon, Nov 30, 2015 at 09:17:26AM -0600, Will Kelleher wrote: > On 11/26, Michael Niedermayer wrote: > > > > I tried to apply this but it seems to doesnt apply cleanly anymore > > id fix the conflicts and apply but i cant test this so i think its > > better if you would fix it > > > > Here is a

Re: [FFmpeg-devel] [PATCH] qsvenc: write a53 caption data to SEI

2015-11-30 Thread Will Kelleher
On 11/26, Michael Niedermayer wrote: > > I tried to apply this but it seems to doesnt apply cleanly anymore > id fix the conflicts and apply but i cant test this so i think its > better if you would fix it > Here is a rebased version. will >From 5452911c08cdb8cebe861d38a9c1b12924120d78 Mon Sep

Re: [FFmpeg-devel] [PATCH] qsvenc: write a53 caption data to SEI

2015-11-26 Thread Michael Niedermayer
On Thu, Nov 12, 2015 at 02:13:08PM +0300, Ivan Uskov wrote: > Hello Will, > > Thursday, November 12, 2015, 12:53:46 AM, you wrote: > > WK> On 11/07, Ivan Uskov wrote: > >> Although the code looks ok by itself, I believe it is bad idea to > >> place > >> H.264-specific codeto the

Re: [FFmpeg-devel] [PATCH] qsvenc: write a53 caption data to SEI

2015-11-12 Thread Ivan Uskov
Hello Will, Thursday, November 12, 2015, 12:53:46 AM, you wrote: WK> On 11/07, Ivan Uskov wrote: >> Although the code looks ok by itself, I believe it is bad idea to place >> H.264-specific codeto the function which is commonfor all >> encoders. I believe H.264-specific

Re: [FFmpeg-devel] [PATCH] qsvenc: write a53 caption data to SEI

2015-11-11 Thread Will Kelleher
On 11/07, Ivan Uskov wrote: > Although the code looks ok by itself, I believe it is bad idea to place > H.264-specific codeto the function which is commonfor all > encoders. I believe H.264-specific user data insertion should locates into > the qsvenc_h264.c > I.e. the

Re: [FFmpeg-devel] [PATCH] qsvenc: write a53 caption data to SEI

2015-11-09 Thread Will Kelleher
On 11/7/15, 12:32 PM, "ffmpeg-devel on behalf of Ivan Uskov" wrote: >Hello Will, > >Saturday, November 7, 2015, 5:29:15 PM, you wrote: > >WK> --- >WK> libavcodec/qsvenc.c | 114 >WK> +-- >WK> libavcodec/qsvenc.h | 2 +- >WK> libavcodec/q

Re: [FFmpeg-devel] [PATCH] qsvenc: write a53 caption data to SEI

2015-11-07 Thread Ivan Uskov
Hello Will, Saturday, November 7, 2015, 5:29:15 PM, you wrote: WK> --- WK> libavcodec/qsvenc.c | 114 WK> +-- WK> libavcodec/qsvenc.h | 2 +- WK> libavcodec/qsvenc_h264.c | 2 +- WK> 3 files changed, 113 insertions(+), 5 deletions(-) WK>

[FFmpeg-devel] [PATCH] qsvenc: write a53 caption data to SEI

2015-11-07 Thread Will Kelleher
--- libavcodec/qsvenc.c | 114 +-- libavcodec/qsvenc.h | 2 +- libavcodec/qsvenc_h264.c | 2 +- 3 files changed, 113 insertions(+), 5 deletions(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index df1f777..0ee45f9 100644 --- a/l