Re: [FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

2016-01-12 Thread Ricardo Constantino
On 12 January 2016 at 05:05, Timothy Gu wrote: > Are you sure you want to initialize libgcrypt unconditionally as you are > doing here? > I don't think it's unconditional. It only tries to initialize gcrypt if it's not been initialized already. >+if (!gcry_control(GCRYCTL_INITIALIZATION

Re: [FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

2016-01-11 Thread Timothy Gu
On Sun, Jan 10, 2016 at 10:04:34PM +, Ricardo Constantino wrote: > Either disabling or init'ing secure memory is required after the use > of gcry_check_version. From a look at the functions rtmpdh uses, I > noticed none require the use of secure memory, so we disable it [1][2]. > > This resol

Re: [FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

2016-01-11 Thread Michael Niedermayer
On Sun, Jan 10, 2016 at 10:04:34PM +, Ricardo Constantino wrote: > On 10 January 2016 at 19:54, Michael Niedermayer > wrote: > > > > > please explain in the commit message why secmem is disabled > > > > > rtmpdh.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > a3406

Re: [FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

2016-01-10 Thread Ricardo Constantino
On 10 January 2016 at 19:54, Michael Niedermayer wrote: > > please explain in the commit message why secmem is disabled > > 0001-rtmpdh-Initialize-gcrypt-before-using-it.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.

Re: [FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

2016-01-10 Thread Michael Niedermayer
On Sun, Jan 10, 2016 at 07:34:27PM +, Ricardo Constantino wrote: > Tried with 1.5.4 with the link on the first email and another one from > Crunchyroll and it worked. > Tried compiling 1.5.0 but didn't work (on MinGW). > rtmpdh.c | 11 ++- > 1 file changed, 10 insertions(+), 1 delet

Re: [FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

2016-01-10 Thread Ricardo Constantino
Tried with 1.5.4 with the link on the first email and another one from Crunchyroll and it worked. Tried compiling 1.5.0 but didn't work (on MinGW). 0001-rtmpdh-Initialize-gcrypt-before-using-it.patch Description: Binary data ___ ffmpeg-devel mailing lis

Re: [FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

2016-01-09 Thread Ricardo Constantino
On 10 January 2016 at 00:17, Ricardo Constantino wrote: > On 9 January 2016 at 23:32, Michael Niedermayer > wrote: > >> >> we should pass the version number we need i think >> see >> >> https://quickgit.kde.org/?p=libktorrent.git&a=commit&h=a23bafe9191e0dcbd5ae75335fd5d8e49bfda9ed >> >> > I woul

Re: [FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

2016-01-09 Thread Ricardo Constantino
On 9 January 2016 at 23:32, Michael Niedermayer wrote: > > we should pass the version number we need i think > see > > https://quickgit.kde.org/?p=libktorrent.git&a=commit&h=a23bafe9191e0dcbd5ae75335fd5d8e49bfda9ed > > I wouldn't know the minimum version FFmpeg needs. Wouldn't it be better to lea

Re: [FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

2016-01-09 Thread Michael Niedermayer
On Mon, Jan 04, 2016 at 02:39:41AM +, Ricardo Constantino wrote: > On 3 January 2016 at 23:13, Jan Ekstrom wrote: > > > Hi, > > > > In general looks good, although it might look a bit weird for someone > > as usually libraries have initialization functions called like that. > > That said, thi

Re: [FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

2016-01-09 Thread Ricardo Constantino
Ping ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

2016-01-03 Thread Ricardo Constantino
On 3 January 2016 at 23:13, Jan Ekstrom wrote: > Hi, > > In general looks good, although it might look a bit weird for someone > as usually libraries have initialization functions called like that. > That said, this is what > > https://gnupg.org/documentation/manuals/gcrypt/Initializing-the-libra

Re: [FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

2016-01-03 Thread Jan Ekstrom
Hi, In general looks good, although it might look a bit weird for someone as usually libraries have initialization functions called like that. That said, this is what https://gnupg.org/documentation/manuals/gcrypt/Initializing-the-library.html recommends. My only comment would be that we might wa

[FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

2015-12-29 Thread Ricardo Constantino
Trying to use gcrypt-enabled FFmpeg with rtmpe returns a few errors: Fatal: failed to create the RNG lock: Invalid argument FATAL: failed to acquire the FSM lock in libgrypt: Invalid argument This is probably not how or where this should be done, but it does fix the problem for me. You can test w