Re: [FFmpeg-devel] [PATCH] snow: remove strange av_assert2

2015-07-10 Thread Andreas Cadhalpun
On 10.07.2015 01:48, Michael Niedermayer wrote: > On Thu, Jul 09, 2015 at 08:16:29PM +0200, Andreas Cadhalpun wrote: >> snow.h |4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> 62ba6bae883891f9953478d52d591e5f16aa759e >> 0001-snow-remove-an-obsolete-av_assert2.patch >> From 7747

Re: [FFmpeg-devel] [PATCH] snow: remove strange av_assert2

2015-07-10 Thread Andreas Cadhalpun
On 10.07.2015 02:12, Michael Niedermayer wrote: > On Thu, Jul 09, 2015 at 08:24:52PM +0200, Andreas Cadhalpun wrote: >> The assert can be triggered by the h264 decoder: >> mc_dir_part in libavcodec/h264_mb.c calls the 16 bit variant of >> emulated_edge_mc and thus the assert is triggered due to the

Re: [FFmpeg-devel] [PATCH] snow: remove strange av_assert2

2015-07-09 Thread Michael Niedermayer
On Thu, Jul 09, 2015 at 08:24:52PM +0200, Andreas Cadhalpun wrote: > On 08.07.2015 18:07, Michael Niedermayer wrote: > > On Wed, Jul 08, 2015 at 07:24:13AM -0400, Ronald S. Bultje wrote: > >> - last of all, I want to remind you guys that we haven't done a very > >> thorough code analysis to see if

Re: [FFmpeg-devel] [PATCH] snow: remove strange av_assert2

2015-07-09 Thread Michael Niedermayer
On Thu, Jul 09, 2015 at 08:16:29PM +0200, Andreas Cadhalpun wrote: > On 08.07.2015 01:22, Michael Niedermayer wrote: > > On Tue, Jul 07, 2015 at 11:32:59PM +0200, Andreas Cadhalpun wrote: > >> I think the assert is a historic leftover: > >> Before commit cc884a35 src_stride > 7*MB_SIZE was necessar

Re: [FFmpeg-devel] [PATCH] snow: remove strange av_assert2

2015-07-09 Thread Andreas Cadhalpun
On 08.07.2015 18:07, Michael Niedermayer wrote: > On Wed, Jul 08, 2015 at 07:24:13AM -0400, Ronald S. Bultje wrote: >> - last of all, I want to remind you guys that we haven't done a very >> thorough code analysis to see if this can actually be triggered. As an >> example, look at commit 458446acfa

Re: [FFmpeg-devel] [PATCH] snow: remove strange av_assert2

2015-07-09 Thread Andreas Cadhalpun
On 08.07.2015 01:22, Michael Niedermayer wrote: > On Tue, Jul 07, 2015 at 11:32:59PM +0200, Andreas Cadhalpun wrote: >> I think the assert is a historic leftover: >> Before commit cc884a35 src_stride > 7*MB_SIZE was necessary, because >> the blocks were interleaved in the tmp buffer and the last bl

Re: [FFmpeg-devel] [PATCH] snow: remove strange av_assert2

2015-07-08 Thread Michael Niedermayer
On Wed, Jul 08, 2015 at 07:24:13AM -0400, Ronald S. Bultje wrote: > Hi, > > On Tue, Jul 7, 2015 at 7:22 PM, Michael Niedermayer > wrote: > > > On Tue, Jul 07, 2015 at 11:32:59PM +0200, Andreas Cadhalpun wrote: > > > On 06.07.2015 02:40, Michael Niedermayer wrote: > > > > On Sun, Jul 05, 2015 at

Re: [FFmpeg-devel] [PATCH] snow: remove strange av_assert2

2015-07-08 Thread Ronald S. Bultje
Hi, On Tue, Jul 7, 2015 at 7:22 PM, Michael Niedermayer wrote: > On Tue, Jul 07, 2015 at 11:32:59PM +0200, Andreas Cadhalpun wrote: > > On 06.07.2015 02:40, Michael Niedermayer wrote: > > > On Sun, Jul 05, 2015 at 09:11:44PM +0200, Andreas Cadhalpun wrote: > > >> Can you explain how elements can

Re: [FFmpeg-devel] [PATCH] snow: remove strange av_assert2

2015-07-07 Thread Michael Niedermayer
On Tue, Jul 07, 2015 at 11:32:59PM +0200, Andreas Cadhalpun wrote: > On 06.07.2015 02:40, Michael Niedermayer wrote: > > On Sun, Jul 05, 2015 at 09:11:44PM +0200, Andreas Cadhalpun wrote: > >> Can you explain how elements can be too larger to fit? > > > > emulated_edge_mc() writes a block of width

Re: [FFmpeg-devel] [PATCH] snow: remove strange av_assert2

2015-07-07 Thread Andreas Cadhalpun
On 06.07.2015 02:40, Michael Niedermayer wrote: > On Sun, Jul 05, 2015 at 09:11:44PM +0200, Andreas Cadhalpun wrote: >> Can you explain how elements can be too larger to fit? > > emulated_edge_mc() writes a block of width x height, More precisely that's block_w x block_h. > if stride < width thi

Re: [FFmpeg-devel] [PATCH] snow: remove strange av_assert2

2015-07-05 Thread Michael Niedermayer
On Sun, Jul 05, 2015 at 09:11:44PM +0200, Andreas Cadhalpun wrote: > On 03.07.2015 01:04, Michael Niedermayer wrote: > > On Fri, Jul 03, 2015 at 12:31:31AM +0200, Andreas Cadhalpun wrote: > >> It asserts that the frame linesize is larger than 37, but it can be > >> smaller and decoding such frames

Re: [FFmpeg-devel] [PATCH] snow: remove strange av_assert2

2015-07-05 Thread Andreas Cadhalpun
On 03.07.2015 01:04, Michael Niedermayer wrote: > On Fri, Jul 03, 2015 at 12:31:31AM +0200, Andreas Cadhalpun wrote: >> It asserts that the frame linesize is larger than 37, but it can be >> smaller and decoding such frames works. Thus it is unclear what this >> assert is good for. > > i think it

Re: [FFmpeg-devel] [PATCH] snow: remove strange av_assert2

2015-07-02 Thread Michael Niedermayer
On Fri, Jul 03, 2015 at 12:31:31AM +0200, Andreas Cadhalpun wrote: > It asserts that the frame linesize is larger than 37, but it can be > smaller and decoding such frames works. Thus it is unclear what this > assert is good for. i think it was due to the layout of some temporary /scratch buffer

[FFmpeg-devel] [PATCH] snow: remove strange av_assert2

2015-07-02 Thread Andreas Cadhalpun
It asserts that the frame linesize is larger than 37, but it can be smaller and decoding such frames works. Thus it is unclear what this assert is good for. Signed-off-by: Andreas Cadhalpun --- This av_assert2 can be triggered with: $ ffmpeg -f lavfi -i testsrc=s=32x32:d=0.1 -c snow snow.nut $ f