Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-02-01 Thread Andreas Cadhalpun
On 01.02.2017 17:25, Steinar H. Gunderson wrote: > On Wed, Feb 01, 2017 at 02:17:05AM +0100, Andreas Cadhalpun wrote: >>> Would you mind sharing an input where this actually triggers? None of the >>> samples I have seem to trigger this, so I suppose it's some sort of fuzzed >>> input. >> Indeed it

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-02-01 Thread Steinar H. Gunderson
On Wed, Feb 01, 2017 at 02:17:05AM +0100, Andreas Cadhalpun wrote: >> Would you mind sharing an input where this actually triggers? None of the >> samples I have seem to trigger this, so I suppose it's some sort of fuzzed >> input. > Indeed it is. I've sent you a sample. Could you please try the a

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-02-01 Thread Michael Niedermayer
On Wed, Feb 01, 2017 at 09:56:41AM +0100, Steinar H. Gunderson wrote: > On Wed, Feb 01, 2017 at 02:17:05AM +0100, Andreas Cadhalpun wrote: > >> Would you mind sharing an input where this actually triggers? None of the > >> samples I have seem to trigger this, so I suppose it's some sort of fuzzed >

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-02-01 Thread Steinar H. Gunderson
On Wed, Feb 01, 2017 at 02:17:05AM +0100, Andreas Cadhalpun wrote: >> Would you mind sharing an input where this actually triggers? None of the >> samples I have seem to trigger this, so I suppose it's some sort of fuzzed >> input. > Indeed it is. I've sent you a sample. Thanks; I see what is happ

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-01-31 Thread Andreas Cadhalpun
On 31.01.2017 09:43, Steinar H. Gunderson wrote: > On Tue, Jan 31, 2017 at 01:57:31AM +0100, Andreas Cadhalpun wrote: >>> This sounds like a strangeness in constructing the table, which shouldn't be >>> papered over in the inner loop of the decoder. >> Maybe, I don't know what the contents of the t

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-01-31 Thread Steinar H. Gunderson
On Tue, Jan 31, 2017 at 01:57:31AM +0100, Andreas Cadhalpun wrote: >> This sounds like a strangeness in constructing the table, which shouldn't be >> papered over in the inner loop of the decoder. > Maybe, I don't know what the contents of the table should be, but the > following > are {-1, 0}: 32

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-01-30 Thread Andreas Cadhalpun
On 31.01.2017 00:59, Steinar H. Gunderson wrote: > On Tue, Jan 31, 2017 at 12:49:56AM +0100, Andreas Cadhalpun wrote: >>> How can you get a negative run, which would be required for this to happen? >> Some values in ff_dc_alpha_run_vlc_le.table are negative, e.g.: >> ff_dc_alpha_run_vlc_le.table[3

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-01-30 Thread Steinar H. Gunderson
On Tue, Jan 31, 2017 at 12:49:56AM +0100, Andreas Cadhalpun wrote: >> How can you get a negative run, which would be required for this to happen? > Some values in ff_dc_alpha_run_vlc_le.table are negative, e.g.: > ff_dc_alpha_run_vlc_le.table[32] = {-1, 0} This sounds like a strangeness in constr

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-01-30 Thread Andreas Cadhalpun
On 30.01.2017 09:23, Steinar H. Gunderson wrote: > How can you get a negative run, which would be required for this to happen? Some values in ff_dc_alpha_run_vlc_le.table are negative, e.g.: ff_dc_alpha_run_vlc_le.table[32] = {-1, 0} Best regards, Andreas ___

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-01-30 Thread Steinar H. Gunderson
On Mon, Jan 30, 2017 at 02:31:08AM +0100, Andreas Cadhalpun wrote: > Fixes out-of-bounds writes. Hi, How can you get a negative run, which would be required for this to happen? /* Steinar */ -- Homepage: https://www.sesse.net/ ___ ffmpeg-devel mailing

[FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-01-29 Thread Andreas Cadhalpun
Fixes out-of-bounds writes. Signed-off-by: Andreas Cadhalpun --- libavcodec/speedhq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/speedhq.c b/libavcodec/speedhq.c index 385f779f83..6ae1e0f8df 100644 --- a/libavcodec/speedhq.c +++ b/libavcodec/speedhq.c @@ -198,