Re: [FFmpeg-devel] [PATCH] vf_blend: Use integers for divide mode

2016-02-22 Thread Martin Vignali
2016-02-23 0:22 GMT+01:00 Ganesh Ajjanagadde : > On Fri, Feb 19, 2016 at 1:06 PM, Martin Vignali > wrote: > > Hello, > > > > Is it necessary to clip value, if B == 0 ? > > Well, integer division by 0 is undefined... > > > > > > > Martin > > > >

Re: [FFmpeg-devel] [PATCH] vf_blend: Use integers for divide mode

2016-02-22 Thread Ganesh Ajjanagadde
On Fri, Feb 19, 2016 at 1:06 PM, Martin Vignali wrote: > Hello, > > Is it necessary to clip value, if B == 0 ? Well, integer division by 0 is undefined... > > > Martin > > 2016-02-19 18:47 GMT+01:00 Timothy Gu : > [...]

Re: [FFmpeg-devel] [PATCH] vf_blend: Use integers for divide mode

2016-02-19 Thread Martin Vignali
Hello, Is it necessary to clip value, if B == 0 ? Martin 2016-02-19 18:47 GMT+01:00 Timothy Gu : > On Sun, Feb 14, 2016 at 10:41:04AM +0100, Paul B Mahol wrote: > > > > ok > > Pushed (last week). Thanks. > > Timothy > ___ >

Re: [FFmpeg-devel] [PATCH] vf_blend: Use integers for divide mode

2016-02-19 Thread Timothy Gu
On Sun, Feb 14, 2016 at 10:41:04AM +0100, Paul B Mahol wrote: > > ok Pushed (last week). Thanks. Timothy ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] vf_blend: Use integers for divide mode

2016-02-14 Thread Paul B Mahol
On 2/14/16, Timothy Gu wrote: > 2.5x faster for 8-bit mode without autovectorization in GCC, 2x > slower with it on x86. However, since the platforms we enable GCC > autovectorization on most probably has support for SSE2 > optimization (added in the subsequent commit),

[FFmpeg-devel] [PATCH] vf_blend: Use integers for divide mode

2016-02-13 Thread Timothy Gu
2.5x faster for 8-bit mode without autovectorization in GCC, 2x slower with it on x86. However, since the platforms we enable GCC autovectorization on most probably has support for SSE2 optimization (added in the subsequent commit), this commit should in general do good. ---