Re: [FFmpeg-devel] [PATCH] vf_v360: fix visibility test for fisheye projection

2021-03-19 Thread Moritz Barsnick
On Fri, Mar 19, 2021 at 20:42:04 +1100, Daniel Playfair Cal wrote: > -const int visible = hypotf(uf, vf) <= 0.5f; > +const int visible = -0.5 < uf && uf < 0.5 && -0.5 < vf && vf < 0.5; Please avoid double constants in float expressions, they propagate the whole calculation to a double.

[FFmpeg-devel] [PATCH] vf_v360: fix visibility test for fisheye projection

2021-03-19 Thread Daniel Playfair Cal
Previously the visibility test referred to a circle in the input. This changes it so that it refers accurately to the entire area in the input. Signed-off-by: Daniel Playfair Cal --- libavfilter/vf_v360.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_v360.c