Re: [FFmpeg-devel] [PATCH] vfi/x86/vf_idet: fix incorrect use of paddq

2014-09-05 Thread Michael Niedermayer
On Fri, Sep 05, 2014 at 12:08:56AM -0700, Pascal Massimino wrote: > James, > > > On Thu, Sep 4, 2014 at 3:22 PM, James Darnley > wrote: > > > paddq is an SSE2 instruction so it cannot be used for MMX. > > > > This was probably just a typo because the sums are dwords anyway. > > --- > > > > We s

Re: [FFmpeg-devel] [PATCH] vfi/x86/vf_idet: fix incorrect use of paddq

2014-09-05 Thread Pascal Massimino
James, On Thu, Sep 4, 2014 at 3:22 PM, James Darnley wrote: > paddq is an SSE2 instruction so it cannot be used for MMX. > > This was probably just a typo because the sums are dwords anyway. > --- > > We should have picked this up in review but we didn't... > > libavfilter/x86/vf_idet.asm |

[FFmpeg-devel] [PATCH] vfi/x86/vf_idet: fix incorrect use of paddq

2014-09-04 Thread James Darnley
paddq is an SSE2 instruction so it cannot be used for MMX. This was probably just a typo because the sums are dwords anyway. --- We should have picked this up in review but we didn't... libavfilter/x86/vf_idet.asm |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavfi