Re: [FFmpeg-devel] [PATCH] x86: cabac: Disable the inline asm on clang on windows on i386

2020-05-29 Thread Martin Storsjö
On Fri, 29 May 2020, Carl Eugen Hoyos wrote: Am 28.05.2020 um 12:37 schrieb Martin Storsjö : Any further comments on this patch? Please wait a few days more, I am not happy about the patch and at least I’d like to understand better why this is a good and why there is no alternative. Fair

Re: [FFmpeg-devel] [PATCH] x86: cabac: Disable the inline asm on clang on windows on i386

2020-05-29 Thread Carl Eugen Hoyos
> Am 28.05.2020 um 12:37 schrieb Martin Storsjö : > >> On Mon, 25 May 2020, Martin Storsjö wrote: >> >>> On Sun, 24 May 2020, Carl Eugen Hoyos wrote: >>> >>> Am So., 24. Mai 2020 um 21:53 Uhr schrieb Martin Storsjö >> : >>> configure --enable-gpl --arch=i686 --cc=clang-cl --ld=lld-link

Re: [FFmpeg-devel] [PATCH] x86: cabac: Disable the inline asm on clang on windows on i386

2020-05-28 Thread Martin Storsjö
On Mon, 25 May 2020, Martin Storsjö wrote: On Sun, 24 May 2020, Carl Eugen Hoyos wrote: Am So., 24. Mai 2020 um 21:53 Uhr schrieb Martin Storsjö : configure --enable-gpl --arch=i686 --cc=clang-cl --ld=lld-link --target-os=win32 --toolchain=msvc --enable-cross-compile --ar=llvm-ar

Re: [FFmpeg-devel] [PATCH] x86: cabac: Disable the inline asm on clang on windows on i386

2020-05-24 Thread Martin Storsjö
On Sun, 24 May 2020, Carl Eugen Hoyos wrote: Am So., 24. Mai 2020 um 21:53 Uhr schrieb Martin Storsjö : configure --enable-gpl --arch=i686 --cc=clang-cl --ld=lld-link --target-os=win32 --toolchain=msvc --enable-cross-compile --ar=llvm-ar --nm=llvm-nm --disable-stripping --extra-cflags=-m32

Re: [FFmpeg-devel] [PATCH] x86: cabac: Disable the inline asm on clang on windows on i386

2020-05-24 Thread Carl Eugen Hoyos
Am So., 24. Mai 2020 um 21:53 Uhr schrieb Martin Storsjö : > configure --enable-gpl --arch=i686 --cc=clang-cl --ld=lld-link > --target-os=win32 --toolchain=msvc --enable-cross-compile --ar=llvm-ar > --nm=llvm-nm --disable-stripping --extra-cflags=-m32 Why are you cross-compiling? On which system

Re: [FFmpeg-devel] [PATCH] x86: cabac: Disable the inline asm on clang on windows on i386

2020-05-24 Thread Martin Storsjö
On Sun, 24 May 2020, Carl Eugen Hoyos wrote: Am Sa., 23. Mai 2020 um 20:35 Uhr schrieb Martin Storsjö : The cabac inline assembly is very brittle to assemble properly on i386 windows with clang; libavcodec/hevc_cabac.c fails to build in the default mode (which is -march=pentium4), it only

Re: [FFmpeg-devel] [PATCH] x86: cabac: Disable the inline asm on clang on windows on i386

2020-05-23 Thread Carl Eugen Hoyos
Am Sa., 23. Mai 2020 um 20:35 Uhr schrieb Martin Storsjö : > > The cabac inline assembly is very brittle to assemble properly > on i386 windows with clang; libavcodec/hevc_cabac.c fails to build > in the default mode (which is -march=pentium4), it only works if > ffmpeg is configured with

[FFmpeg-devel] [PATCH] x86: cabac: Disable the inline asm on clang on windows on i386

2020-05-23 Thread Martin Storsjö
The cabac inline assembly is very brittle to assemble properly on i386 windows with clang; libavcodec/hevc_cabac.c fails to build in the default mode (which is -march=pentium4), it only works if ffmpeg is configured with --cpu=i686 (translating to -march=i686), and likewise, the inline assembly