Re: [FFmpeg-devel] [PATCH]lavf/icodec: Improve probe function

2016-01-17 Thread Carl Eugen Hoyos
Michael Bradshaw gmail.com> writes: > > +return AVPROBE_SCORE_MAX / 4 + 1; > > A score of 26 seems low to me, but maybe that's just me. Increased the score and pushed. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH]lavf/icodec: Improve probe function

2016-01-12 Thread Carl Eugen Hoyos
Hi! Attached patch improves ico probing, previously mpeg-2 frames could be detected. Please comment, Carl Eugen diff --git a/libavformat/icodec.c b/libavformat/icodec.c index 22e2099..c3e87ea 100644 --- a/libavformat/icodec.c +++ b/libavformat/icodec.c @@ -44,8 +44,12 @@ typedef struct {

Re: [FFmpeg-devel] [PATCH]lavf/icodec: Improve probe function

2016-01-12 Thread Michael Niedermayer
On Tue, Jan 12, 2016 at 01:49:37PM +0100, Carl Eugen Hoyos wrote: > Hi! > > On Tuesday 12 January 2016 01:33:53 pm Carl Eugen Hoyos wrote: > > > > Attached patch improves ico probing, previously mpeg-2 frames could be > > detected. > > Wikipedia claims that planes can be 0, new patch attached. >

Re: [FFmpeg-devel] [PATCH]lavf/icodec: Improve probe function

2016-01-12 Thread Carl Eugen Hoyos
Hi! On Tuesday 12 January 2016 01:33:53 pm Carl Eugen Hoyos wrote: > > Attached patch improves ico probing, previously mpeg-2 frames could be > detected. Wikipedia claims that planes can be 0, new patch attached. Carl Eugen diff --git a/libavformat/icodec.c b/libavformat/icodec.c index

Re: [FFmpeg-devel] [PATCH]lavf/icodec: Improve probe function

2016-01-12 Thread Carl Eugen Hoyos
On Tuesday 12 January 2016 02:49:59 pm Michael Niedermayer wrote: > On Tue, Jan 12, 2016 at 01:49:37PM +0100, Carl Eugen Hoyos wrote: > > Hi! > > > > On Tuesday 12 January 2016 01:33:53 pm Carl Eugen Hoyos wrote: > > > Attached patch improves ico probing, previously mpeg-2 frames could be > > >

Re: [FFmpeg-devel] [PATCH]lavf/icodec: Improve probe function

2016-01-12 Thread Michael Niedermayer
On Tue, Jan 12, 2016 at 08:33:47AM -0800, Michael Bradshaw wrote: > Overall it looks good. I thought it might overflow the buffer but with > AVPROBE_PADDING_SIZE it doesn't. > > On Tue, Jan 12, 2016 at 7:09 AM, Carl Eugen Hoyos wrote: > > diff --git a/libavformat/icodec.c

Re: [FFmpeg-devel] [PATCH]lavf/icodec: Improve probe function

2016-01-12 Thread Michael Bradshaw
Overall it looks good. I thought it might overflow the buffer but with AVPROBE_PADDING_SIZE it doesn't. On Tue, Jan 12, 2016 at 7:09 AM, Carl Eugen Hoyos wrote: > diff --git a/libavformat/icodec.c b/libavformat/icodec.c > index 22e2099..9cf3dca 100644 > ---