Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (v2)

Hi, 2016-02-14 0:43 GMT+01:00 Michael Niedermayer : > i can test and commit the code, it seems everyone who wanted to > comment did comment Yes, nothing really worth postponing the patchset from my side, except maybe cleaner splitting of the bypass stuff, as agreed by the

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (v2)

On Wed, Feb 03, 2016 at 12:47:47PM +, John Cox wrote: > On Tue, 2 Feb 2016 12:52:15 +0100, you wrote: > > >Hi, > > > >as a motus operandi for this review, I have no time for a proper one, > >or at least not fitting with John's timeframe. I'll try to close as > >many pending discussions, and

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (v2)

On Tue, 2 Feb 2016 12:52:15 +0100, you wrote: >Hi, > >as a motus operandi for this review, I have no time for a proper one, >or at least not fitting with John's timeframe. I'll try to close as >many pending discussions, and would prefer if someone else completed >the review/validation/commit. Do

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (v2)

Hi, as a motus operandi for this review, I have no time for a proper one, or at least not fitting with John's timeframe. I'll try to close as many pending discussions, and would prefer if someone else completed the review/validation/commit. 2016-01-22 19:33 GMT+01:00 John Cox

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (v2)

On Sat, Jan 23, 2016 at 01:40:53AM -0300, James Almer wrote: > On 1/21/2016 11:39 PM, Michael Niedermayer wrote: > > On Thu, Jan 21, 2016 at 10:45:55AM +, John Cox wrote: > >> Hi > >> > >> v2 of my hevc residual patch > >> > >> I've fixed the fate regression > >> I've split it into more pieces

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (v2)

On Fri, 22 Jan 2016 18:52:23 +0100, you wrote: >Hi, > >2016-01-21 11:45 GMT+01:00 John Cox : >> Hi >> >> v2 of my hevc residual patch > >I'll review the bit not related to significant coeffs first, because I >think it is the most performance-sensitive. Also there are bits that

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (v2)

>On Fri, Jan 22, 2016 at 01:41:11AM +0100, Michael Niedermayer wrote: >> On Thu, Jan 21, 2016 at 10:45:55AM +, John Cox wrote: >> > Hi >> > >> > v2 of my hevc residual patch >> > >> > I've fixed the fate regression >> > I've split it into more pieces >> > Now uses ff_clz >> > Some

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (v2)

On Fri, 22 Jan 2016 01:57:58 +0100, you wrote: >On Fri, Jan 22, 2016 at 01:41:11AM +0100, Michael Niedermayer wrote: >> On Thu, Jan 21, 2016 at 10:45:55AM +, John Cox wrote: >> > Hi >> > >> > v2 of my hevc residual patch >> > >> > I've fixed the fate regression >> > I've split it into more

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (v2)

On Fri, 22 Jan 2016 14:42:27 +0100, you wrote: > [snip] >> >fate-hevc passes with patch 1-5, so the issue is likely in the last >> > >> >[...] >> >> Yup - bug in the arm update_rice (again - sorry). Now passes fate on >> ARM too (now I've learnt how to run fate on my Pi in a finite time). >>

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (v2)

On Fri, Jan 22, 2016 at 12:32:00PM +, John Cox wrote: > On Fri, 22 Jan 2016 01:57:58 +0100, you wrote: > > >On Fri, Jan 22, 2016 at 01:41:11AM +0100, Michael Niedermayer wrote: > >> On Thu, Jan 21, 2016 at 10:45:55AM +, John Cox wrote: > >> > Hi > >> > > >> > v2 of my hevc residual patch

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (v2)

Hi, 2016-01-21 11:45 GMT+01:00 John Cox : > Hi > > v2 of my hevc residual patch I'll review the bit not related to significant coeffs first, because I think it is the most performance-sensitive. Also there are bits that could be moved to other patches, at least some are

[FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (v2)

Hi v2 of my hevc residual patch I've fixed the fate regression I've split it into more pieces Now uses ff_clz Some reformating of function headers The patches can also be found on https://github.com/jc-kynesim/rpi-ffmpeg.git on branch test/ff_hevc_cabac_4 from tag ff_hevc_cabac_4_base Note

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (v2)

On Fri, Jan 22, 2016 at 08:38:15AM +0530, Ganesh Ajjanagadde wrote: > On Fri, Jan 22, 2016 at 8:09 AM, Michael Niedermayer > wrote: > > On Thu, Jan 21, 2016 at 10:45:55AM +, John Cox wrote: > >> Hi > >> > >> v2 of my hevc residual patch > >> > >> I've fixed the fate

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (v2)

On Fri, Jan 22, 2016 at 01:41:11AM +0100, Michael Niedermayer wrote: > On Thu, Jan 21, 2016 at 10:45:55AM +, John Cox wrote: > > Hi > > > > v2 of my hevc residual patch > > > > I've fixed the fate regression > > I've split it into more pieces > > Now uses ff_clz > > Some reformating of

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (v2)

On Thu, Jan 21, 2016 at 10:45:55AM +, John Cox wrote: > Hi > > v2 of my hevc residual patch > > I've fixed the fate regression > I've split it into more pieces > Now uses ff_clz > Some reformating of function headers > > The patches can also be found on >

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (v2)

On Fri, Jan 22, 2016 at 8:09 AM, Michael Niedermayer wrote: > On Thu, Jan 21, 2016 at 10:45:55AM +, John Cox wrote: >> Hi >> >> v2 of my hevc residual patch >> >> I've fixed the fate regression >> I've split it into more pieces >> Now uses ff_clz >> Some reformating of

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (v2)

On Thu, Jan 21, 2016 at 10:45:55AM +, John Cox wrote: > Hi > > v2 of my hevc residual patch > > I've fixed the fate regression > I've split it into more pieces > Now uses ff_clz > Some reformating of function headers > > The patches can also be found on >