[FFmpeg-devel] [PATCH 0/1] re: Add Sega FILM muxer

2018-04-02 Thread misty
From: Misty De Meo > I assume you copied the demuxer but shouldn't you be here as well? Good point, added! > I honestly think your comment style (i.e. C vs C++) should be consistent > throughout the file, but that's just me. OK, updated all the single-line comments to

[FFmpeg-devel] [PATCH 0/1] re: Add Sega FILM muxer

2018-04-01 Thread misty
From: Misty De Meo I've resolved the one TODO that remained by adding support for the one other supported video codec in this container. Is there anything else that you'd like to see changed? I understand the concerns about this too niche, but I have been speaking to a

[FFmpeg-devel] [PATCH 0/1] re: Add Sega FILM muxer

2018-03-26 Thread misty
From: Misty De Meo I reviewed the contributing guide one more time, and noticed I'd missed two items from the new muxer list. Updated the patch with: * Marked Sega FILM as having a muxer in general.texi * Bumped the minor version of libavformat Misty De Meo (1): Add

[FFmpeg-devel] [PATCH 0/1] re: Add Sega FILM muxer

2018-03-23 Thread misty
From: Misty De Meo > Just move allocation after all declarations. OK, changed. > Do you check that this condition is set in code? > > I mean, if user set codec for wrong case. Oh, good point. I thought about this, and then realized that for mono audio, there is no