Re: [FFmpeg-devel] [PATCH 03/11] ffserver_config: map ffserver options to AVOptions

2014-11-26 Thread Reynaldo H. Verdejo Pinochet
Hi On 11/21/2014 09:16 PM, Lukasz Marek wrote: [...] @@ -497,6 +500,14 @@ static int ffserver_save_avoption(const char *opt, const char *arg, int type, FF return 0; } +static int ffserver_save_avoption_int(const char *opt, int64_t arg, + int

Re: [FFmpeg-devel] [PATCH 03/11] ffserver_config: map ffserver options to AVOptions

2014-11-26 Thread Lukasz Marek
On 26.11.2014 23:22, Reynaldo H. Verdejo Pinochet wrote: Hi On 11/21/2014 09:16 PM, Lukasz Marek wrote: [...] @@ -497,6 +500,14 @@ static int ffserver_save_avoption(const char *opt, const char *arg, int type, FF return 0; } +static int ffserver_save_avoption_int(const char *opt,

Re: [FFmpeg-devel] [PATCH 03/11] ffserver_config: map ffserver options to AVOptions

2014-11-26 Thread Reynaldo H. Verdejo Pinochet
On 11/26/2014 07:52 PM, Lukasz Marek wrote: [..] In fact 20 is too small. INT64_MIN has 19 digits, '-' sign and terminating 0. So 21 is a minimum. I put 22, the same as av_dict_set_int. True, forgot about the sign. Go ahead after fixing please. Thanks, -- Reynaldo H. Verdejo Pinochet

Re: [FFmpeg-devel] [PATCH 03/11] ffserver_config: map ffserver options to AVOptions

2014-11-21 Thread Reynaldo H. Verdejo Pinochet
Hi On 11/20/2014 10:14 PM, Lukasz Marek wrote: On 18.11.2014 21:35, Reynaldo H. Verdejo Pinochet wrote: [...] Also, please make an effort to break lines at 80 chars as long as it doesn't make the code harder to read. This seems particularly possible on the function declarations.

Re: [FFmpeg-devel] [PATCH 03/11] ffserver_config: map ffserver options to AVOptions

2014-11-21 Thread Reynaldo H. Verdejo Pinochet
On 11/21/2014 07:17 PM, Reynaldo H. Verdejo Pinochet wrote: [..] suggestion many avid by. s/avid by/follow/g ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 03/11] ffserver_config: map ffserver options to AVOptions

2014-11-20 Thread Lukasz Marek
On 18.11.2014 21:35, Reynaldo H. Verdejo Pinochet wrote: Hi On 11/16/2014 10:46 PM, Lukasz Marek wrote: Signed-off-by: Lukasz Marek lukasz.m.lu...@gmail.com [..] @@ -965,43 +881,38 @@ static int ffserver_parse_config_stream(FFServerConfig *config, const char *cmd, ret =

Re: [FFmpeg-devel] [PATCH 03/11] ffserver_config: map ffserver options to AVOptions

2014-11-18 Thread Reynaldo H. Verdejo Pinochet
Hi On 11/16/2014 10:46 PM, Lukasz Marek wrote: Signed-off-by: Lukasz Marek lukasz.m.lu...@gmail.com [..] @@ -965,43 +881,38 @@ static int ffserver_parse_config_stream(FFServerConfig *config, const char *cmd, ret = av_parse_video_size(w, h, arg); if (ret 0)

Re: [FFmpeg-devel] [PATCH 03/11] ffserver_config: map ffserver options to AVOptions

2014-11-17 Thread Reynaldo H. Verdejo Pinochet
Hi On 11/16/2014 11:03 PM, Lukasz Marek wrote: On 17.11.2014 02:46, Lukasz Marek wrote: Signed-off-by: Lukasz Marek lukasz.m.lu...@gmail.com --- ffserver_config.c | 237 -- ffserver_config.h | 2 - 2 files changed, 69

Re: [FFmpeg-devel] [PATCH 03/11] ffserver_config: map ffserver options to AVOptions

2014-11-16 Thread Lukasz Marek
On 17.11.2014 02:46, Lukasz Marek wrote: Signed-off-by: Lukasz Marek lukasz.m.lu...@gmail.com --- ffserver_config.c | 237 -- ffserver_config.h | 2 - 2 files changed, 69 insertions(+), 170 deletions(-) @Reynaldo, you may check the test