Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-20 Thread Lukasz Marek
On 20.11.2014 02:17, Michael Niedermayer wrote: [...] +{ +AVDictionary *dict = NULL; +char *buffer = NULL; + +printf("Testing av_dict_get_string() and av_dict_parse_string()"); +av_dict_get_string(dict, &buffer, '=', ','); +printf("%s\n", buffer); +av_freep(&buffer); +

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-19 Thread Michael Niedermayer
On Wed, Nov 19, 2014 at 11:24:06PM +0100, Lukasz Marek wrote: > On 19.11.2014 21:50, Lukasz Marek wrote: > >On 19-Nov-2014 8:59 pm, "Michael Niedermayer" >> wrote: > > > > > > On Wed, Nov 19, 2014 at 02:25:48AM +0100, Lukasz Marek wrote: > > > > On 19.11.2014 01:13, Michae

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-19 Thread Lukasz Marek
On 19.11.2014 21:50, Lukasz Marek wrote: On 19-Nov-2014 8:59 pm, "Michael Niedermayer" mailto:michae...@gmx.at>> wrote: > > On Wed, Nov 19, 2014 at 02:25:48AM +0100, Lukasz Marek wrote: > > On 19.11.2014 01:13, Michael Niedermayer wrote: > > >On Wed, Nov 19, 2014 at 12:30:53AM +0100, Lukasz M

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-19 Thread Lukasz Marek
On 19-Nov-2014 8:59 pm, "Michael Niedermayer" wrote: > > On Wed, Nov 19, 2014 at 02:25:48AM +0100, Lukasz Marek wrote: > > On 19.11.2014 01:13, Michael Niedermayer wrote: > > >On Wed, Nov 19, 2014 at 12:30:53AM +0100, Lukasz Marek wrote: > > >>On 18.11.2014 20:47, Michael Niedermayer wrote: > > >>

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-19 Thread Michael Niedermayer
On Wed, Nov 19, 2014 at 02:25:48AM +0100, Lukasz Marek wrote: > On 19.11.2014 01:13, Michael Niedermayer wrote: > >On Wed, Nov 19, 2014 at 12:30:53AM +0100, Lukasz Marek wrote: > >>On 18.11.2014 20:47, Michael Niedermayer wrote: > >how will that work without any way to identify the version or f

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-18 Thread Michael Niedermayer
On Wed, Nov 19, 2014 at 02:25:48AM +0100, Lukasz Marek wrote: > On 19.11.2014 01:13, Michael Niedermayer wrote: > >On Wed, Nov 19, 2014 at 12:30:53AM +0100, Lukasz Marek wrote: > >>On 18.11.2014 20:47, Michael Niedermayer wrote: > >how will that work without any way to identify the version or f

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-18 Thread Lukasz Marek
On 19.11.2014 01:13, Michael Niedermayer wrote: On Wed, Nov 19, 2014 at 12:30:53AM +0100, Lukasz Marek wrote: On 18.11.2014 20:47, Michael Niedermayer wrote: how will that work without any way to identify the version or format? also a serialization stream thats self containd seems much nicer t

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-18 Thread Michael Niedermayer
On Wed, Nov 19, 2014 at 12:30:53AM +0100, Lukasz Marek wrote: > On 18.11.2014 20:47, Michael Niedermayer wrote: > >>>how will that work without any way to identify the version or format? > >>> > >>>also a serialization stream thats self containd seems much nicer to > >>>handle as theres no need to

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-18 Thread Lukasz Marek
On 18.11.2014 20:47, Michael Niedermayer wrote: how will that work without any way to identify the version or format? also a serialization stream thats self containd seems much nicer to handle as theres no need to keep track of the exact version (if we end up having more than 1) the used seperat

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-18 Thread Michael Niedermayer
On Tue, Nov 18, 2014 at 08:00:51PM +0100, Lukasz Marek wrote: > On 18 November 2014 03:31, Michael Niedermayer wrote: > > > > > >It should be also possible to serialize an empty dictionary > > > > > > > >the serialization string should also contain a serialization format > > > >identifer/version o

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-18 Thread Lukasz Marek
On 18 November 2014 03:31, Michael Niedermayer wrote: > > > >It should be also possible to serialize an empty dictionary > > > > > >the serialization string should also contain a serialization format > > >identifer/version otherwise future maintaince could become hard > > >this identifer should sp

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-18 Thread Michael Niedermayer
On Tue, Nov 18, 2014 at 01:30:31PM +0100, Lukasz Marek wrote: > On 18 November 2014 11:56, Michael Niedermayer wrote: > > > On Mon, Nov 17, 2014 at 02:46:54AM +0100, Lukasz Marek wrote: > > > TODO: bump minor, update doc/APIchanges > > > > also please make sure the version you add to doc/APIchang

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-18 Thread Lukasz Marek
On 18 November 2014 11:56, Michael Niedermayer wrote: > On Mon, Nov 17, 2014 at 02:46:54AM +0100, Lukasz Marek wrote: > > TODO: bump minor, update doc/APIchanges > > also please make sure the version you add to doc/APIchanges matches > what you set in version.h > Did I add wrong before?

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-18 Thread Michael Niedermayer
On Mon, Nov 17, 2014 at 02:46:54AM +0100, Lukasz Marek wrote: > TODO: bump minor, update doc/APIchanges also please make sure the version you add to doc/APIchanges matches what you set in version.h [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is what and w

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-17 Thread Michael Niedermayer
On Tue, Nov 18, 2014 at 01:28:42AM +0100, Lukasz Marek wrote: > On 17.11.2014 14:01, Michael Niedermayer wrote: > >On Mon, Nov 17, 2014 at 02:46:54AM +0100, Lukasz Marek wrote: > >>TODO: bump minor, update doc/APIchanges > >> > >>Signed-off-by: Lukasz Marek > >>--- > >> libavutil/dict.c | 27

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-17 Thread Lukasz Marek
On 17.11.2014 14:01, Michael Niedermayer wrote: On Mon, Nov 17, 2014 at 02:46:54AM +0100, Lukasz Marek wrote: TODO: bump minor, update doc/APIchanges Signed-off-by: Lukasz Marek --- libavutil/dict.c | 27 +++ libavutil/dict.h | 16 2 files changed,

Re: [FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-17 Thread Michael Niedermayer
On Mon, Nov 17, 2014 at 02:46:54AM +0100, Lukasz Marek wrote: > TODO: bump minor, update doc/APIchanges > > Signed-off-by: Lukasz Marek > --- > libavutil/dict.c | 27 +++ > libavutil/dict.h | 16 > 2 files changed, 43 insertions(+) > > diff --git a/libav

[FFmpeg-devel] [PATCH 07/11] lavu/dict: add av_dict_serialize

2014-11-16 Thread Lukasz Marek
TODO: bump minor, update doc/APIchanges Signed-off-by: Lukasz Marek --- libavutil/dict.c | 27 +++ libavutil/dict.h | 16 2 files changed, 43 insertions(+) diff --git a/libavutil/dict.c b/libavutil/dict.c index 475e906..a41d61e 100644 --- a/libavutil/dic