Re: [FFmpeg-devel] [PATCH 1/2] avcodec/gdv: Remove dead check

2020-11-07 Thread Paul B Mahol
lgtm On Sat, Nov 7, 2020 at 2:30 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > At the end of its decode function, the decoder sets *got_frame to 1 and > then checks whether ret is < 0; if so, it is returned, otherwise > avpkt->size is. But it is impossible for ret to be < 0 here

[FFmpeg-devel] [PATCH 1/2] avcodec/gdv: Remove dead check

2020-11-06 Thread Andreas Rheinhardt
At the end of its decode function, the decoder sets *got_frame to 1 and then checks whether ret is < 0; if so, it is returned, otherwise avpkt->size is. But it is impossible for ret to be < 0 here and if it were, it would be nonsense to set *got_frame to 1 before this. Therefore just return avpkt->