Re: [FFmpeg-devel] [PATCH 1/2] avformat/aviobuf: add ff_read_line_to_bprint and ff_read_line_to_bprint_overwrite functions

2018-02-24 Thread Marton Balint
On Wed, 14 Feb 2018, Nicolas George wrote: Marton Balint (2018-02-11): It is a 500% speed improvement on a 260 MB line compared to using av_bprint_chars, so I'd rather leave it as is. I can add a comment saying "for performance reasons we fill a temporary buffer, and use av_bprint functions

Re: [FFmpeg-devel] [PATCH 1/2] avformat/aviobuf: add ff_read_line_to_bprint and ff_read_line_to_bprint_overwrite functions

2018-02-14 Thread Nicolas George
Marton Balint (2018-02-11): > It is a 500% speed improvement on a 260 MB line compared to using > av_bprint_chars, so I'd rather leave it as is. I can add a comment saying > "for performance reasons we fill a temporary buffer, and use av_bprint > functions on chunks of data". This is assuming

Re: [FFmpeg-devel] [PATCH 1/2] avformat/aviobuf: add ff_read_line_to_bprint and ff_read_line_to_bprint_overwrite functions

2018-02-11 Thread Marton Balint
On Sun, 11 Feb 2018, Nicolas George wrote: Marton Balint (2018-02-10): To be able to read lines longer than a static buffer size. Signed-off-by: Marton Balint --- libavformat/aviobuf.c | 46 ++ libavformat/internal.h | 26

Re: [FFmpeg-devel] [PATCH 1/2] avformat/aviobuf: add ff_read_line_to_bprint and ff_read_line_to_bprint_overwrite functions

2018-02-11 Thread Nicolas George
Marton Balint (2018-02-10): > To be able to read lines longer than a static buffer size. > > Signed-off-by: Marton Balint > --- > libavformat/aviobuf.c | 46 ++ > libavformat/internal.h | 26 ++ > 2 files

[FFmpeg-devel] [PATCH 1/2] avformat/aviobuf: add ff_read_line_to_bprint and ff_read_line_to_bprint_overwrite functions

2018-02-10 Thread Marton Balint
To be able to read lines longer than a static buffer size. Signed-off-by: Marton Balint --- libavformat/aviobuf.c | 46 ++ libavformat/internal.h | 26 ++ 2 files changed, 72 insertions(+) diff --git